| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250827012210.399aae3d@elisabeth>
Date: Wed, 27 Aug 2025 01:22:10 +0200
From: Stefano Brivio <sbrivio@...hat.com>
To: Paul Wayper <pwayper@...hat.com>
Cc: Stephen Hemminger <stephen@...workplumber.org>, netdev@...r.kernel.org,
paulway@...hat.com, jbainbri@...hat.com
Subject: Re: [PATCH iproute2] ss: Don't pad the last (enabled) column
On Tue, 26 Aug 2025 10:22:37 +1000
Paul Wayper <pwayper@...hat.com> wrote:
> ss will emit spaces on the right hand side of a left-justified, enabled
> column even if it's the last column. In situations where one or more
> lines are very long - e.g. because of a large PROCESS field value - this
> causes a lot of excess output.
>
> Firstly, calculate the last enabled column. Then use this in the check
> for whether to emit trailing spaces on the last column.
>
> Also name the 'EXT' column as 'Details' and mark it as disabled by
> default, enabled when the -e or --extended options are supplied.
>
> Fixes: 59f46b7b5be86 ("ss: Introduce columns lightweight abstraction")
> Signed-off-by: Paul Wayper <paulway@...hat.com>
> ---
> misc/ss.c | 42 +++++++++++++++++++++++++++++++++---------
> 1 file changed, 33 insertions(+), 9 deletions(-)
For some reason I didn't investigate yet, this still breaks ss -tunl as
well as ss -tunap for me. With 115 columns, before:
$ ss -tunl
Netid State Recv-Q Send-Q Local Address:Port Peer Address:Port
udp UNCONN 0 0 192.168.122.1:53 0.0.0.0:*
udp UNCONN 0 0 0.0.0.0%virbr0:67 0.0.0.0:*
udp UNCONN 0 0 0.0.0.0:111 0.0.0.0:*
udp UNCONN 0 0 0.0.0.0:33335 0.0.0.0:*
...
$ ss -tunap
Netid State Recv-Q Send-Q Local Address:Port Peer Address:Port Process
udp UNCONN 0 0 192.168.122.1:53 0.0.0.0:*
udp UNCONN 0 0 0.0.0.0%virbr0:67 0.0.0.0:*
udp ESTAB 0 0 192.168.1.185%wlp4s0:68 192.168.1.1:67
...
and after:
$ ./ss -tunl
Netid State Recv-Q Send-Q Local Address:Port Peer Address:Port
udp UNCONN 0 0 192.168.122.1: 530.0.0.0:
* udp UNCONN 0 0 0.0.0.0%virbr0:67
0.0.0.0: * udp UNCONN0 0 0.0.0.0:
111 0.0.0.0: * udpUNCONN 0 0
0.0.0.0: 33335 0.0.0.0: * udp UNCONN0
0 0.0.0.0: 5154 0.0.0.0: * udpUNCONN
...
$ ./ss -tunap
Netid State Recv-Q Send-Q Local Address:Port Peer Address:Port Process
udp UNCONN 0 0 192.168.122.1: 530.0.0.0: *
udp UNCONN 0 0 0.0.0.0%virbr0:67 0.0.0.0:
* udp ESTAB0 0 192.168.1.185%wlp4s0: 68
192.168.1.1: 67 udpUNCONN 0 0 0.0.0.0:
111 0.0.0.0: * udp UNCONN0 0
0.0.0.0: 33335 0.0.0.0: * udpUNCONN 0
...
I'll look into this soon, give me a couple of days. I still have to
answer some points from 137a3493-bbda-490f-8ad4-fa3a511c2742@...hat.com
as well.
--
Stefano
Powered by blists - more mailing lists