netdev - Re: [PATCH net-next v2 4/6] eth: fbnic: Fetch PHY stats from device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <670c145e-a70b-4bc5-9450-dd590e162143@intel.com>
Date: Tue, 26 Aug 2025 16:35:20 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <mohsin.bashr@...il.com>,
	<vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH net-next v2 4/6] eth: fbnic: Fetch PHY stats from device



On 8/25/2025 1:02 PM, Jakub Kicinski wrote:
> From: Mohsin Bashir <mohsin.bashr@...il.com>
> 
> Add support to fetch PHY stats consisting of PCS and FEC stats from the
> device. When reading the stats counters, the lo part is read first, which
> latches the hi part to ensure consistent reading of the stats counter.
> 
> FEC and PCS stats can wrap depending on the access frequency. To prevent
> wrapping, fetch these stats periodically under the service task. Also to
> maintain consistency fetch these stats along with other 32b stats under
> __fbnic_get_hw_stats32().
> 
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)