netdev - Re: [PATCH net] net: mana: Remove redundant netdev_lock_ops_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250826045709.GA2238@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Mon, 25 Aug 2025 21:57:09 -0700
From: Saurabh Singh Sengar <ssengar@...ux.microsoft.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com,
	shradhagupta@...ux.microsoft.com, ernis@...ux.microsoft.com,
	dipayanroy@...ux.microsoft.com, shirazsaleem@...rosoft.com,
	linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, ssengar@...rosoft.com,
	stable@...r.kernel.org
Subject: Re: [PATCH net] net: mana: Remove redundant
 netdev_lock_ops_to_full() calls

On Mon, Aug 25, 2025 at 05:41:33PM -0700, Jakub Kicinski wrote:
> On Mon, 25 Aug 2025 04:03:14 -0700 Saurabh Sengar wrote:
> > NET_SHAPER is always selected for MANA driver. When NET_SHAPER is enabled,
> > netdev_lock_ops_to_full() reduces effectively to only an assert for lock,
> > which is always held in the path when NET_SHAPER is enabled.
> > 
> > Remove the redundant netdev_lock_ops_to_full() call.
> > 
> > Fixes: d5c8f0e4e0cb ("net: mana: Fix potential deadlocks in mana napi ops")
> > Cc: stable@...r.kernel.org
> 
> If the call is a nop why is this a stable-worthy fix?

I am fine removing CC and fixes tag.
I can send a V2 for it.


- Saurabh