netdev - Re: [PATCH net-next] net: phy: fixed: let fixed_phy_add always use addr 0 and remove return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175625521749.151180.6244131462600024014.git-patchwork-notify@kernel.org>
Date: Wed, 27 Aug 2025 00:40:17 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: gerg@...ux-m68k.org, geert@...ux-m68k.org, hauke@...ke-m.de,
 zajec5@...il.com, tsbogend@...ha.franken.de, andrew@...n.ch,
 andrew+netdev@...n.ch, linux@...linux.org.uk, pabeni@...hat.com,
 edumazet@...gle.com, kuba@...nel.org, davem@...emloft.net,
 netdev@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
 linux-mips@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: fixed: let fixed_phy_add always use
 addr 0
 and remove return value

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 22 Aug 2025 22:36:11 +0200 you wrote:
> We have only two users of fixed_phy_add(), both use address 0 and
> ignore the return value. So simplify fixed_phy_add() accordingly.
> 
> Whilst at it, constify the fixed_phy_status configs.
> 
> Note:
> fixed_phy_add() is a legacy function which shouldn't be used in new
> code, as it's use may be problematic:
> - No check whether a fixed phy exists already at the given address
> - If fixed_phy_register() is called afterwards by any other driver,
>   then it will also use phy_addr 0, because fixed_phy_add() ignores
>   the ida which manages address assignment
> Drivers using a fixed phy created by fixed_phy_add() in platform code,
> should dynamically create a fixed phy with fixed_phy_register()
> instead.
> 
> [...]

Here is the summary with links:
  - [net-next] net: phy: fixed: let fixed_phy_add always use addr 0 and remove return value
    https://git.kernel.org/netdev/net-next/c/39e94fdce45f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html