netdev - Re: [PATCH] net: aquantia: Remove redundant ternary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aK7oFUHS0l9w3MdI@opensource>
Date: Wed, 27 Aug 2025 11:12:21 +0000
From: Subbaraya Sundeep <sbhatta@...vell.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>
CC: Igor Russkikh <irusskikh@...vell.com>,
        Andrew Lunn
	<andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric
 Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>,
        "open list:AQUANTIA ETHERNET DRIVER (atlantic)"
	<netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: aquantia: Remove redundant ternary operators

On 2025-08-27 at 09:58:33, Liao Yuanhong (liaoyuanhong@...o.com) wrote:
> For ternary operators in the form of "a ? true : false", if 'a' itself
> returns a boolean result, the ternary operator can be omitted. Remove
> redundant ternary operators to clean up the code.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>

Reviewed-by: Subbaraya Sundeep <sbhatta@...vell.com>
> ---
>  drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> index 7e88d7234b14..f5e0f784ec56 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> @@ -463,8 +463,7 @@ bool hw_atl_utils_ver_match(u32 ver_expected, u32 ver_actual)
>  	ver_match = (dw_major_mask & (ver_expected ^ ver_actual)) ? false : true;
>  	if (!ver_match)
>  		goto err_exit;
> -	ver_match = ((dw_minor_mask & ver_expected) > (dw_minor_mask & ver_actual)) ?
> -		false : true;
> +	ver_match = (dw_minor_mask & ver_expected) <= (dw_minor_mask & ver_actual);
>  
>  err_exit:
>  	return ver_match;
> -- 
> 2.34.1
>