netdev - Re: [PATCH bpf-next v4] selftests/bpf: Add LPM trie microbenchmarks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAENh_SQo2-28P-QnN2Jga_dq_3qc451RS0Wc1UQuvxqvK+NM6A@mail.gmail.com>
Date: Wed, 27 Aug 2025 12:27:34 +0100
From: Matt Fleming <matt@...dmodwrite.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>, Shuah Khan <shuah@...nel.org>, 
	kernel-team <kernel-team@...udflare.com>, Jesper Dangaard Brouer <hawk@...nel.org>, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	bpf <bpf@...r.kernel.org>, Martin KaFai Lau <martin.lau@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, Network Development <netdev@...r.kernel.org>, 
	Matt Fleming <mfleming@...udflare.com>
Subject: Re: [PATCH bpf-next v4] selftests/bpf: Add LPM trie microbenchmarks

On Wed, Aug 27, 2025 at 12:50 AM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Tue, Aug 26, 2025 at 6:12 AM Matt Fleming <matt@...dmodwrite.com> wrote:
> >
> > +static int baseline(__u32 index, __u32 *unused)
> > +{
> > +       struct trie_key key;
> > +       __s64 blackbox;
> > +
> > +       generate_key(&key);
> > +       /* Avoid compiler optimizing out the modulo */
> > +       barrier_var(blackbox);
> > +       blackbox = READ_ONCE(key.data);
>
> Overall looks good, but gcc-bpf found an actual issue.

Thanks. I'll submit a v5 with a fix shortly.