netdev - [PATCH net-next] net: hinic: Remove redundant ternary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250827121413.496600-1-liaoyuanhong@vivo.com>
Date: Wed, 27 Aug 2025 20:14:12 +0800
From: Liao Yuanhong <liaoyuanhong@...o.com>
To: Cai Huoqing <cai.huoqing@...ux.dev>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org (open list:HUAWEI ETHERNET DRIVER),
	linux-kernel@...r.kernel.org (open list)
Cc: Liao Yuanhong <liaoyuanhong@...o.com>
Subject: [PATCH net-next] net: hinic: Remove redundant ternary operators

For ternary operators in the form of "a ? true : false", if 'a' itself
returns a boolean result, the ternary operator can be omitted. Remove
redundant ternary operators to clean up the code.

Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
---
 drivers/net/ethernet/huawei/hinic/hinic_devlink.c | 3 +--
 drivers/net/ethernet/huawei/hinic/hinic_port.c    | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
index 03e42512a2d5..6655831a7dda 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
@@ -174,8 +174,7 @@ static int hinic_flash_fw(struct hinic_devlink_priv *priv, const u8 *data,
 			memset(fw_update_msg->data, 0, MAX_FW_FRAGMENT_LEN);
 
 			fw_update_msg->ctl_info.SF =
-				(section_remain_send_len == section_len) ?
-				true : false;
+				section_remain_send_len == section_len;
 			fw_update_msg->section_info.FW_section_CRC = section_crc;
 			fw_update_msg->fw_section_version = section_version;
 			fw_update_msg->ctl_info.flag = UP_TYPE_A;
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_port.c b/drivers/net/ethernet/huawei/hinic/hinic_port.c
index 486fb0e20bef..776904345554 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_port.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_port.c
@@ -1357,7 +1357,7 @@ static bool hinic_if_sfp_absent(struct hinic_hwdev *hwdev)
 		return true;
 	}
 
-	return ((sfp_abs.abs_status == 0) ? false : true);
+	return sfp_abs.abs_status != 0;
 }
 
 int hinic_get_sfp_eeprom(struct hinic_hwdev *hwdev, u8 *data, u16 *len)
-- 
2.34.1