netdev - Re: [PATCH net-next v2 1/2] dt-bindings: net: mxl: Add MxL LGM Network Processor SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <182444f3-6d94-46de-94d2-afa70d863db5@kernel.org>
Date: Wed, 27 Aug 2025 14:33:54 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jack Ping CHNG <jchng@...linear.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org
Cc: davem@...emloft.net, andrew+netdev@...n.ch, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, yzhu@...linear.com, sureshnagaraj@...linear.com
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: mxl: Add MxL LGM
 Network Processor SoC

On 26/08/2025 05:10, Jack Ping CHNG wrote:
> +maintainers:
> +  - Jack Ping Chng <jchng@...linear.com>
> +
> +description:
> +  Binding for MaxLinear LGM Ethernet controller
> +
> +properties:
> +  compatible:
> +    enum:
> +      - mxl,lgm-eth

No such vendor prefix.

> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: ethif
> +
> +  resets:
> +    maxItems: 1
> +
> +  '#address-cells':
> +    const: 1

Blank line

> +  '#size-cells':
> +    const: 0
> +
> +patternProperties:
> +  "^interface@[1-4]$":

Use consistent quotes, either ' or "

I don't quite get what's this node is for.

> +    type: object
> +    properties:
> +      compatible:
> +        const: mxl,lgm-mac
> +
> +      reg:
> +        minimum: 1
> +        maximum: 4
> +
> +    required:
> +      - compatible
> +      - reg
> +
> +required:
> +  - compatible
> +  - clocks
> +  - clock-names
> +  - '#address-cells'
> +  - '#size-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    eth {

ethernet? How is it called everywhere else?

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +      compatible = "mxl,lgm-eth";
> +      clocks = <&cgu0 32>;
> +      clock-names = "ethif";
> +      resets = <&rcu0 0x70 8>;
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      mac: interface@1 {
> +        compatible = "mxl,eth-mac";
> +        reg = <1>;

No resources here, so this is not really a subnode... unless you wanted
to reference something from ethernet controllers.

This looks pretty incomplete.

> +      };
> +    };


Best regards,
Krzysztof