netdev - Re: [PATCH net-next v7 2/5] net: spacemit: Add K1 Ethernet MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b83e78a-0456-4b43-9380-0e2b83933246@iscas.ac.cn>
Date: Wed, 27 Aug 2025 21:17:23 +0800
From: Vivian Wang <wangruikang@...as.ac.cn>
To: Philipp Zabel <p.zabel@...gutronix.de>,
 Andrew Lunn <andrew+netdev@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>
Cc: Vivian Wang <uwu@...m.page>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Junhui Liu <junhui.liu@...moral.tech>, Simon Horman <horms@...nel.org>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v7 2/5] net: spacemit: Add K1 Ethernet MAC

Hi Philipp,

Thanks for your review.

On 8/26/25 16:54, Philipp Zabel wrote:
> On Di, 2025-08-26 at 14:23 +0800, Vivian Wang wrote:
>> The Ethernet MACs found on SpacemiT K1 appears to be a custom design
>> that only superficially resembles some other embedded MACs. SpacemiT
>> refers to them as "EMAC", so let's just call the driver "k1_emac".
>>
>> Supports RGMII and RMII interfaces. Includes support for MAC hardware
>> statistics counters. PTP support is not implemented.
>>
>> Tested-by: Junhui Liu <junhui.liu@...moral.tech>
>> Signed-off-by: Vivian Wang <wangruikang@...as.ac.cn>
>> Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
>> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
>> ---
>>  drivers/net/ethernet/Kconfig            |    1 +
>>  drivers/net/ethernet/Makefile           |    1 +
>>  drivers/net/ethernet/spacemit/Kconfig   |   29 +
>>  drivers/net/ethernet/spacemit/Makefile  |    6 +
>>  drivers/net/ethernet/spacemit/k1_emac.c | 2193 +++++++++++++++++++++++++++++++
>>  drivers/net/ethernet/spacemit/k1_emac.h |  426 ++++++
>>  6 files changed, 2656 insertions(+)
>>
> [...]
>> diff --git a/drivers/net/ethernet/spacemit/k1_emac.c b/drivers/net/ethernet/spacemit/k1_emac.c
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..9e558d5893cfbbda0baa7ad21a7209dadda9487e
>> --- /dev/null
>> +++ b/drivers/net/ethernet/spacemit/k1_emac.c
>> @@ -0,0 +1,2193 @@
> [...]
>> +static int emac_probe(struct platform_device *pdev)
>> +{
>> +	struct device *dev = &pdev->dev;
>> +	struct reset_control *reset;
>> +	struct net_device *ndev;
>> +	struct emac_priv *priv;
>> +	int ret;
>> +
>> +	ndev = devm_alloc_etherdev(dev, sizeof(struct emac_priv));
>> +	if (!ndev)
>> +		return -ENOMEM;
>> +
>> +	ndev->hw_features = NETIF_F_SG;
>> +	ndev->features |= ndev->hw_features;
>> +
>> +	ndev->max_mtu = EMAC_RX_BUF_4K - (ETH_HLEN + ETH_FCS_LEN);
>> +
>> +	priv = netdev_priv(ndev);
>> +	priv->ndev = ndev;
>> +	priv->pdev = pdev;
>> +	platform_set_drvdata(pdev, priv);
>> +
>> +	ret = emac_config_dt(pdev, priv);
>> +	if (ret < 0) {
>> +		dev_err_probe(dev, ret, "Configuration failed\n");
>> +		goto err;
> I'd just
> 		return dev_err_probe(...);
> here.
>
>> +	}
>> +
>> +	ndev->watchdog_timeo = 5 * HZ;
>> +	ndev->base_addr = (unsigned long)priv->iobase;
>> +	ndev->irq = priv->irq;
>> +
>> +	ndev->ethtool_ops = &emac_ethtool_ops;
>> +	ndev->netdev_ops = &emac_netdev_ops;
>> +
>> +	devm_pm_runtime_enable(&pdev->dev);
>> +
>> +	priv->bus_clk = devm_clk_get_enabled(&pdev->dev, NULL);
>> +	if (IS_ERR(priv->bus_clk)) {
>> +		ret = dev_err_probe(dev, PTR_ERR(priv->bus_clk),
>> +				    "Failed to get clock\n");
>> +		goto err;
> Same here.
>
>> +	}
>> +
>> +	reset = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,
>> +								     NULL);
>> +	if (IS_ERR(reset)) {
>> +		ret = dev_err_probe(dev, PTR_ERR(reset),
>> +				    "Failed to get reset\n");
>> +		goto err;
> And here.
>
>> +	}
>> +
>> +	emac_sw_init(priv);
>> +
>> +	if (of_phy_is_fixed_link(dev->of_node)) {
>> +		ret = of_phy_register_fixed_link(dev->of_node);
>> +		if (ret) {
>> +			dev_err_probe(dev, ret,
>> +				      "Failed to register fixed-link");
>> +			goto err_timer_delete;
> If you can move this section before emac_sw_init(), this could also
> just return.
I'll take a look on these and clean up in next version, thanks.
>> +		}
> Then here a function calling of_phy_deregister_fixed_link() could be
> registered with devm_add_action_or_reset(), to avoid duplicated cleanup
> in the error path and in emac_remove().

I'll deal with this. This should be fine, as it's probe-time only.

Thanks,
Vivian "dramforever" Wang