netdev - Re: [PATCH net-next v14 4/5] net: ti: icssm-prueth: Adds link detection, RX and TX support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250827090820.12a58d22@kernel.org>
Date: Wed, 27 Aug 2025 09:08:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parvathi Pudi <parvathi@...thit.com>
Cc: danishanwar@...com, rogerq@...nel.org, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 ssantosh@...nel.org, richardcochran@...il.com, m-malladi@...com,
 s.hauer@...gutronix.de, afd@...com, jacob.e.keller@...el.com,
 horms@...nel.org, johan@...nel.org, m-karicheri2@...com, s-anna@...com,
 glaroque@...libre.com, saikrishnag@...vell.com, kory.maincent@...tlin.com,
 diogo.ivo@...mens.com, javier.carrasco.cruz@...il.com,
 basharath@...thit.com, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, vadim.fedorenko@...ux.dev,
 alok.a.tiwari@...cle.com, bastien.curutchet@...tlin.com, pratheesh@...com,
 prajith@...com, vigneshr@...com, praneeth@...com, srk@...com,
 rogerq@...com, krishna@...thit.com, pmohan@...thit.com, mohan@...thit.com
Subject: Re: [PATCH net-next v14 4/5] net: ti: icssm-prueth: Adds link
 detection, RX and TX support.

On Fri, 22 Aug 2025 20:09:16 +0530 Parvathi Pudi wrote:
> +	struct net_device_stats *ndevstats;

> +	ndevstats = &emac->ndev->stats;

Please don't use netdev stats, quoting the header:

	struct net_device_stats	stats; /* not used by modern drivers */

Store the counters you need in driver's private struct and implement
.ndo_get_stats64

> +	if (!pkt_info->sv_frame) {

sv_frame seems to always be false at this stage?
Maybe delete this diff if that's the case, otherwise it feels like
the skb_free below should be accompanied by some stat increment.

> +		skb_put(skb, actual_pkt_len);
> +
> +		/* send packet up the stack */
> +		skb->protocol = eth_type_trans(skb, ndev);
> +		netif_receive_skb(skb);
> +	} else {
> +		dev_kfree_skb_any(skb);
> +	}

The rest LGTM.