netdev - Re: [PATCH v17 00/22] Type2 device basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cf568ac801b967365679737774a6c59475fd594.camel@kernel.org>
Date: Wed, 27 Aug 2025 09:48:43 -0700
From: PJ Waskiewicz <ppwaskie@...nel.org>
To: alejandro.lucero-palau@....com, linux-cxl@...r.kernel.org, 
	netdev@...r.kernel.org, dan.j.williams@...el.com, edward.cree@....com, 
	davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, 	dave.jiang@...el.com
Cc: Alejandro Lucero <alucerop@....com>
Subject: Re: [PATCH v17 00/22] Type2 device basic support

On Tue, 2025-06-24 at 15:13 +0100, alejandro.lucero-palau@....com
wrote:

Hi Alejandro,

> From: Alejandro Lucero <alucerop@....com>
> 
> v17 changes: (Dan Williams review)
>  - use devm for cxl_dev_state allocation
>  - using current cxl struct for checking capability registers found
> by
>    the driver.
>  - simplify dpa initialization without a mailbox not supporting pmem
>  - add cxl_acquire_endpoint for protection during initialization
>  - add callback/action to cxl_create_region for a driver notified
> about cxl
>    core kernel modules removal.
>  - add sfc function to disable CXL-based PIO buffers if such a
> callback
>    is invoked.
>  - Always manage a Type2 created region as private not allowing DAX.
> 

I've been following the patches here since your initial RFC.  What
platform are you testing these on out of curiosity?

I've tried pulling the v16 patches into my test environment, and on CXL
2.0 hosts that I have access to, the patches did not work when trying
to hook up a Type 2 device.  Most of it centered around many of the CXL
host registers you try poking not existing.  I do have CXL-capable BIOS
firmware on these hosts, but I'm questioning that either there's still
missing firmware, or the patches are trying to touch something that
doesn't exist.

I'm working on rebasing to the v17 patches to see if this resolves what
I'm seeing.  But it's a bit of a lift, so I figured I'd ask what you're
testing on before burning more time.

Eventually I'd like to either give a Tested-by or shoot back some
amended patches based on testing.  But I've not been able to get that
far yet...

Cheers,
-PJ