netdev - Re: [PATCH net] net: rose: fix a typo in rose_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUAPJFzz5PRbrYi2+RU3sZOV71MSfL=T_iP=xo76JoaE9A@mail.gmail.com>
Date: Wed, 27 Aug 2025 10:30:36 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, syzbot+2eb8d1719f7cfcfa6840@...kaller.appspotmail.com, 
	Takamitsu Iwai <takamitz@...zon.co.jp>
Subject: Re: [PATCH net] net: rose: fix a typo in rose_clear_routes()

On Wed, Aug 27, 2025 at 10:21 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> syzbot crashed in rose_clear_routes(), after a recent patch typo.
>
> KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017]
> CPU: 0 UID: 0 PID: 10591 Comm: syz.3.1856 Not tainted syzkaller #0 PREEMPT(full)
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
>  RIP: 0010:rose_clear_routes net/rose/rose_route.c:565 [inline]
>  RIP: 0010:rose_rt_ioctl+0x162/0x1250 net/rose/rose_route.c:760
>  <TASK>
>   rose_ioctl+0x3ce/0x8b0 net/rose/af_rose.c:1381
>   sock_do_ioctl+0xd9/0x300 net/socket.c:1238
>   sock_ioctl+0x576/0x790 net/socket.c:1359
>   vfs_ioctl fs/ioctl.c:51 [inline]
>   __do_sys_ioctl fs/ioctl.c:598 [inline]
>   __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:584
>   do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
>   do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
>  entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> Fixes: da9c9c877597 ("net: rose: include node references in rose_neigh refcount")
> Reported-by: syzbot+2eb8d1719f7cfcfa6840@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/netdev/68af3e29.a70a0220.3cafd4.002e.GAE@google.com/T/#u
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Thanks for the fix !