netdev - Re: [PATCH v3 net] net: phy: fixed_phy: fix missing calls to gpiod_put in fixed_mdio_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f390adf-5ee2-44cd-8793-36b04f1fe73f@gmail.com>
Date: Wed, 27 Aug 2025 14:14:54 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>,
 Heiner Kallweit <hkallweit1@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net] net: phy: fixed_phy: fix missing calls to
 gpiod_put in fixed_mdio_bus_exit

On 8/27/25 14:09, Russell King (Oracle) wrote:
> On Wed, Aug 27, 2025 at 11:02:55PM +0200, Heiner Kallweit wrote:
>> Cleanup in fixed_mdio_bus_exit() misses to call gpiod_put().
>> Easiest fix is to call fixed_phy_del() for each possible phy address.
>> This may consume a few cpu cycles more, but is much easier to read.
>>
>> Fixes: a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.")
> 
> Here's a question that should be considered as well. Do we still need
> to keep the link-gpios for fixed-phy?
> 
> $ grep -r link-gpios arch/*/boot/dts/
> arch/arm/boot/dts/nxp/vf/vf610-zii-dev-rev-b.dts:                              link-gpios = <&gpio6 2
> arch/arm/boot/dts/nxp/vf/vf610-zii-dev-rev-b.dts:                              link-gpios = <&gpio6 3
> 
> These are used with the mv88e6xxx DSA switch, and DSA being fully
> converted to phylink, means that fixed-phy isn't used for these
> link-gpios properties, and hasn't been for some time.
> 
> So, is this now redundant code that can be removed, or should we
> consider updating it for another kernel cycle but print a deprecation
> notice should someone use it (e.g. openwrt.)
> 
> Should we also describe the SFF modules on Zii rev B properly?
> 

Do we need to maintain the ZII Device Tree sources given that there has 
not been any work done on those, and it's unclear if they are still even 
as useful as they once were?
-- 
Florian