Message-ID: <20250827224641.415806-1-anthony.l.nguyen@intel.com>
Date: Wed, 27 Aug 2025 15:46:15 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: davem@...emloft.net,
	kuba@...nel.org,
	pabeni@...hat.com,
	edumazet@...gle.com,
	andrew+netdev@...n.ch,
	netdev@...r.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
	przemyslaw.kitszel@...el.com,
	gregkh@...uxfoundation.org,
	sashal@...nel.org,
	kuniyu@...gle.com
Subject: [PATCH net-next 00/12][pull request] ice: split ice_virtchnl.c git-blame friendly way

Przemek Kitszel says:

Split ice_virtchnl.c into two more files (+headers), in a way
that git-blame works better.
Then move virtchnl files into a new subdir.
No logic changes.

I have developed (or discovered ;)) how to split a file in a way that
both old and new are nice in terms of git-blame
There was not much discussion on [RFC], so I would like to propose
to go forward with this approach.

There are more commits needed to have it nice, so it forms a git-log vs
git-blame tradeoff, but (after the brief moment that this is on the top)
we spend orders of magnitude more time looking at the blame output (and
commit messages linked from that) - so I find it much better to see
actual logic changes instead of "move xx to yy" stuff (typical for
"squashed/single-commit splits").

Cherry-picks/rebases work the same with this method as with simple
"squashed/single-commit" approach (literally all commits squashed into
one (to have better git-log, but shitty git-blame output).

Rationale for the split itself is, as usual, "file is big and we want to
extend it".

Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
---
I would really look at the fork via your preferred git interaction tool
instead of looking at the patches below.

Note:
The simple git-email view flattens this series, removing two merges from
the view.

Changes:
- Drop the "ice_" and "virtchnl_" substrings in file names, to keep the
naming convention we established when extracting devlink/

IWL v1:
https://lore.kernel.org/netdev/20250812132910.99626-1-przemyslaw.kitszel@intel.com/

[RFC]:
https://lore.kernel.org/netdev/5b94d14e-a0e7-47bd-82fc-c85171cbf26e@intel.com/T/#u

The following are changes since commit cd31182c80e8ec02dacd1d56b91c31e5c7d2c580:
  Merge branch 'selftests-test-xdp_tx-for-single-buffer'
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE

Przemek Kitszel (12):
  ice: add virt/ and move ice_virtchnl* files there
  ice: split queue stuff out of virtchnl.c - tmp rename
  ice: split queue stuff out of virtchnl.c - copy back
  ice: extract virt/queues.c: cleanup - p1
  ice: extract virt/queues.c: cleanup - p2
  ice: extract virt/queues.c: cleanup - p3
  ice: finish virtchnl.c split into queues.c
  ice: split RSS stuff out of virtchnl.c - tmp rename
  ice: split RSS stuff out of virtchnl.c - copy back
  ice: extract virt/rss.c: cleanup - p1
  ice: extract virt/rss.c: cleanup - p2
  ice: finish virtchnl.c split into rss.c

 drivers/net/ethernet/intel/ice/Makefile            |    8 +-
 drivers/net/ethernet/intel/ice/ice_sriov.c         |    2 +-
 drivers/net/ethernet/intel/ice/ice_sriov.h         |    4 +-
 drivers/net/ethernet/intel/ice/ice_vf_lib.c        |    2 +-
 drivers/net/ethernet/intel/ice/ice_vf_lib.h        |    2 +-
 .../{ice_virtchnl_allowlist.c => virt/allowlist.c} |    2 +-
 .../{ice_virtchnl_allowlist.h => virt/allowlist.h} |    0
 .../intel/ice/{ice_virtchnl_fdir.c => virt/fdir.c} |    0
 .../intel/ice/{ice_virtchnl_fdir.h => virt/fdir.h} |    0
 drivers/net/ethernet/intel/ice/virt/queues.c       |  975 ++++++++++
 drivers/net/ethernet/intel/ice/virt/queues.h       |   20 +
 drivers/net/ethernet/intel/ice/virt/rss.c          |  719 +++++++
 drivers/net/ethernet/intel/ice/virt/rss.h          |   18 +
 .../intel/ice/{ice_virtchnl.c => virt/virtchnl.c}  | 2055 ++------------------
 .../intel/ice/{ice_virtchnl.h => virt/virtchnl.h}  |    0
 15 files changed, 1933 insertions(+), 1874 deletions(-)

Powered by blists - more mailing lists