netdev - Re: [PATCH v2 net-next 3/5] net: add sk->sk_drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUBQZiy=mAK6dpHsoMt5ExQR=f4qpY9hEV_X+r=+p+7nOg@mail.gmail.com>
Date: Tue, 26 Aug 2025 22:30:36 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH v2 net-next 3/5] net: add sk->sk_drop_counters

On Tue, Aug 26, 2025 at 5:50 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Some sockets suffer from heavy false sharing on sk->sk_drops,
> and fields in the same cache line.
>
> Add sk->sk_drop_counters to:
>
> - move the drop counter(s) to dedicated cache lines.
> - Add basic NUMA awareness to these drop counter(s).
>
> Following patches will use this infrastructure for UDP and RAW sockets.
>
> sk_clone_lock() is not yet ready, it would need to properly
> set newsk->sk_drop_counters if we plan to use this for TCP sockets.
>
> v2: used Paolo suggestion from https://lore.kernel.org/netdev/8f09830a-d83d-43c9-b36b-88ba0a23e9b2@redhat.com/
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>