netdev - Re: [PATCH v2 net 3/3] net: rose: include node references in rose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUAtFWD0gsuY1zCodD=ZGY=-FQnG+=Qve8cQ1yKkVq3i8Q@mail.gmail.com>
Date: Tue, 26 Aug 2025 23:48:17 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Takamitsu Iwai <takamitz@...zon.co.jp>
Cc: linux-hams@...r.kernel.org, netdev@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kohei Enju <enjuk@...zon.com>, Ingo Molnar <mingo@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Jesper Dangaard Brouer <hawk@...nel.org>, 
	Nikita Zhandarovich <n.zhandarovich@...tech.ru>, 
	syzbot+942297eecf7d2d61d1f1@...kaller.appspotmail.com
Subject: Re: [PATCH v2 net 3/3] net: rose: include node references in
 rose_neigh refcount

On Sat, Aug 23, 2025 at 2:01 AM Takamitsu Iwai <takamitz@...zon.co.jp> wrote:
>
> Current implementation maintains two separate reference counting
> mechanisms: the 'count' field in struct rose_neigh tracks references from
> rose_node structures, while the 'use' field (now refcount_t) tracks
> references from rose_sock.
>
> This patch merges these two reference counting systems using 'use' field
> for proper reference management. Specifically, this patch adds incrementing
> and decrementing of rose_neigh->use when rose_neigh->count is incremented
> or decremented.
>
> This patch also modifies rose_rt_free(), rose_rt_device_down() and
> rose_clear_route() to properly release references to rose_neigh objects
> before freeing a rose_node through rose_remove_node().
>
> These changes ensure rose_neigh structures are properly freed only when
> all references, including those from rose_node structures, are released.
> As a result, this resolves a slab-use-after-free issue reported by Syzbot.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: syzbot+942297eecf7d2d61d1f1@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=942297eecf7d2d61d1f1
> Signed-off-by: Takamitsu Iwai <takamitz@...zon.co.jp>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>