netdev - RE: [Intel-wired-lan] [PATCH v2 iwl-next 1/2] igbvf: add lbtx_packets and lbtx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8985A48DCC9AC13F4970757B8F3BA@IA3PR11MB8985.namprd11.prod.outlook.com>
Date: Thu, 28 Aug 2025 10:12:46 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <horms@...nel.org>, Kohei Enju <enjuk@...zon.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Nguyen,
 Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"kohei.enju@...il.com" <kohei.enju@...il.com>, Paul Menzel
	<pmenzel@...gen.mpg.de>
Subject: RE: [Intel-wired-lan] [PATCH v2 iwl-next 1/2] igbvf: add lbtx_packets
 and lbtx_bytes to ethtool statistics

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Simon
> Horman
> Sent: Wednesday, August 27, 2025 2:27 PM
> To: Kohei Enju <enjuk@...zon.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; kohei.enju@...il.com; Paul Menzel
> <pmenzel@...gen.mpg.de>
> Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/2] igbvf: add lbtx_packets and
> lbtx_bytes to ethtool statistics
> 
> On Tue, Aug 19, 2025 at 12:18:26AM +0900, Kohei Enju wrote:
> > Currently ethtool shows lbrx_packets and lbrx_bytes (Good RX
> > Packets/Octets loopback Count), but doesn't show the TX-side
> > equivalents (lbtx_packets and lbtx_bytes). Add visibility of those
> > missing statistics by adding them to ethtool statistics.
> >
> > In addition, the order of lbrx_bytes and lbrx_packets is not
> > consistent with non-loopback statistics (rx_packets, rx_bytes).
> > Therefore, align the order by swapping positions of lbrx_bytes and lbrx_packets.
> >
> > Tested on Intel Corporation I350 Gigabit Network Connection.
> >
> > Before:
> >   # ethtool -S ens5 | grep -E "x_(bytes|packets)"
> >        rx_packets: 135
> >        tx_packets: 106
> >        rx_bytes: 16010
> >        tx_bytes: 12451
> >        lbrx_bytes: 1148
> >        lbrx_packets: 12
> >
> > After:
> >   # ethtool -S ens5 | grep -E "x_(bytes|packets)"
> >        rx_packets: 748
> >        tx_packets: 304
> >        rx_bytes: 81513
> >        tx_bytes: 33698
> >        lbrx_packets: 97
> >        lbtx_packets: 109
> >        lbrx_bytes: 12090
> >        lbtx_bytes: 12401
> >
> > Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> > Signed-off-by: Kohei Enju <enjuk@...zon.com>
> 
> Reviewed-by: Simon Horman <horms@...nel.org>


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>