[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aLBKOH2nSkiNppwQ@hu-wasimn-hyd.qualcomm.com>
Date: Thu, 28 Aug 2025 17:53:20 +0530
From: Wasim Nazir <wasim.nazir@....qualcomm.com>
To: Bjorn Andersson <andersson@...nel.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Richard Cochran <richardcochran@...il.com>, kernel@....qualcomm.com,
linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
netdev@...r.kernel.org,
Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>,
Sushrut Shree Trivedi <quic_sushruts@...cinc.com>,
Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>,
Krishna Kurapati <krishna.kurapati@....qualcomm.com>,
Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>,
Dikshita Agarwal <quic_dikshita@...cinc.com>,
Monish Chunara <quic_mchunara@...cinc.com>,
Vishal Kumar Pal <quic_vispal@...cinc.com>
Subject: Re: [PATCH 3/5] arm64: dts: qcom: lemans-evk: Extend peripheral and
subsystem support
On Wed, Aug 27, 2025 at 06:06:04PM -0500, Bjorn Andersson wrote:
> On Tue, Aug 26, 2025 at 11:51:02PM +0530, Wasim Nazir wrote:
> > Enhance the Qualcomm Lemans EVK board file to support essential
> > peripherals and improve overall hardware capabilities, as
> > outlined below:
> > - Enable GPI (Generic Peripheral Interface) DMA-0/1/2 and QUPv3-0/2
> > controllers to facilitate DMA and peripheral communication.
> > - Add support for PCIe-0/1, including required regulators and PHYs,
> > to enable high-speed external device connectivity.
> > - Integrate the TCA9534 I/O expander via I2C to provide 8 additional
> > GPIO lines for extended I/O functionality.
> > - Enable the USB0 controller in device mode to support USB peripheral
> > operations.
> > - Activate remoteproc subsystems for supported DSPs such as Audio DSP,
> > Compute DSP-0/1 and Generic DSP-0/1, along with their corresponding
> > firmware.
> > - Configure nvmem-layout on the I2C EEPROM to store data for Ethernet
> > and other consumers.
> > - Enable the QCA8081 2.5G Ethernet PHY on port-0 and expose the
> > Ethernet MAC address via nvmem for network configuration.
> > It depends on CONFIG_QCA808X_PHY to use QCA8081 PHY.
> > - Add support for the Iris video decoder, including the required
> > firmware, to enable video decoding capabilities.
> > - Enable SD-card slot on SDHC.
>
> I know I asked for you to lump things together in the initial
> contribution to provide as much features as possible in that initial
> patch, but now that is in place and this patch really is a bunch of
> independent logical changes and this commit message reads much more like
> a cover letter...
>
> >
> > Co-developed-by: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>
> > Signed-off-by: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>
> > Co-developed-by: Sushrut Shree Trivedi <quic_sushruts@...cinc.com>
> > Signed-off-by: Sushrut Shree Trivedi <quic_sushruts@...cinc.com>
> > Co-developed-by: Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>
> > Signed-off-by: Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>
> > Co-developed-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
> > Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
> > Co-developed-by: Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>
> > Signed-off-by: Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>
> > Co-developed-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
> > Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
> > Co-developed-by: Monish Chunara <quic_mchunara@...cinc.com>
> > Signed-off-by: Monish Chunara <quic_mchunara@...cinc.com>
> > Co-developed-by: Vishal Kumar Pal <quic_vispal@...cinc.com>
> > Signed-off-by: Vishal Kumar Pal <quic_vispal@...cinc.com>
> > Signed-off-by: Wasim Nazir <wasim.nazir@....qualcomm.com>
>
> And I don't think you all wrote this patch, you probably all wrote
> individual pieces and then one of you created the actual patch?
>
> The important part is that we don't want 9 different patch series
> floating around with unmet dependencies and relying on me to try to
> stitch them together.
>
> But if you could do what you did for patch 2, 4, and 5 for logical
> chunks of this change, that would be excellent (i.e. you collect the
> individual patches, you add your signed-off-by, and you send them all
> together).
Sure Bjorn, I will split it in next version of the same series.
--
Regards,
Wasim
Powered by blists - more mailing lists