netdev - Re: [PATCH v3] icmp: fix icmp_ndo_send address translation for reply direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLBQBPdYE9pNmXOy@strlen.de>
Date: Thu, 28 Aug 2025 14:48:04 +0200
From: Florian Westphal <fw@...len.de>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: Fabian Bläse <fabian@...ese.de>,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	"Jason A. Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH v3] icmp: fix icmp_ndo_send address translation for reply
 direction

Pablo Neira Ayuso <pablo@...filter.org> wrote:
> > So I believe its needed, concurrent update of ->status is possible and
> > KCSAN would warn.  Other spots either use READ_ONCE or use test_bit().
> 
> There are a more checks for ct->status & NAT_MASK in the tree that I
> can see, if you are correct, then maybe a new helper function to check
> for NAT_MASK is needed.

I think it would make sense to add a helper, yes.
Independent of this patch of course.