netdev - Re: [PATCH] net: igb: expose rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29cbde11-b7bc-4eba-a0ea-b20e4a9ecb79@linux.dev>
Date: Thu, 28 Aug 2025 14:18:38 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Ranganath V N <vnranganath.20@...il.com>, przemyslaw.kitszel@...el.com,
 andrew+netdev@...n.ch, davem@...emloft.net, kuba@...nel.org,
 pabeni@...hat.com
Cc: linux-kernel-mentees@...ts.linuxfoundation.org,
 skhan@...uxfoundation.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, anthony.l.nguyen@...el.com,
 intel-wired-lan@...ts.osuosl.org, edumazet@...gle.com
Subject: Re: [PATCH] net: igb: expose rx_dropped via ethtool -S

On 28/08/2025 12:42, Ranganath V N wrote:
> Currently the igb driver does not reports RX dropped
> packets in the ethtool -S statistics output, even though
> this information is already available in struct
> rtnl_link_stats64.
> 
> This patch adds rx_dropped, so users can monitor dropped
> packet counts directly with ethtool.
> 
> Signed-off-by: Ranganath V N <vnranganath.20@...il.com>
> ---
>   drivers/net/ethernet/intel/igb/igb_ethtool.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index 92ef33459aec..3c6289e80ba0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -81,6 +81,7 @@ static const struct igb_stats igb_gstrings_stats[] = {
>   }
>   static const struct igb_stats igb_gstrings_net_stats[] = {
>   	IGB_NETDEV_STAT(rx_errors),
> +	IGB_NETDEV_STAT(rx_dropped),
>   	IGB_NETDEV_STAT(tx_errors),
>   	IGB_NETDEV_STAT(tx_dropped),
>   	IGB_NETDEV_STAT(rx_length_errors),

This stat is never used in the igb driver, what's the benefit of
constant 0 value in the output?