netdev - Re: [PATCH net-next 0/7] net: stmmac: fixes and new features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49a2237a-840f-4233-a6c3-008311f223ba@linux.dev>
Date: Thu, 28 Aug 2025 14:21:22 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Konrad Leszczynski <konrad.leszczynski@...el.com>,
 Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, andrew+netdev@...n.ch, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, cezary.rojewski@...el.com,
 sebastian.basierski@...el.com
Subject: Re: [PATCH net-next 0/7] net: stmmac: fixes and new features

On 28/08/2025 13:51, Konrad Leszczynski wrote:
> 
> On 28-Aug-25 14:25, Andrew Lunn wrote:
>> On Thu, Aug 28, 2025 at 08:47:02AM +0200, Konrad Leszczynski wrote:
>>> On 26-Aug-25 19:29, Vadim Fedorenko wrote:
>>>> On 26/08/2025 12:32, Konrad Leszczynski wrote:
>>>>> This series starts with three fixes addressing KASAN panic on ethtool
>>>>> usage, Enhanced Descriptor printing and flow stop on TC block setup 
>>>>> when
>>>>> interface down.
>>>>> Everything that follows adds new features such as ARP Offload support,
>>>>> VLAN protocol detection and TC flower filter support.
>>>> Well, mixing fixes and features in one patchset is not a great idea.
>>>> Fixes patches should have Fixes: tags and go to -net tree while 
>>>> features
>>>> should go to net-next. It's better to split series into 2 and provide
>>>> proper tags for the "fixes" part
>>> Hi Vadim,
>>>
>>> Thanks for the review. I've specifically placed the fixes first and the
>>> features afterwards to not intertwine the patches. I can split them 
>>> into two
>>> patchsets if you think that's the best way to go.
>> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>>
>> You probably need to wait a week between the fixes and new features in
>> order that net and net-next are synced.
>>
>>      Andrew
>>
>> ---
>> pw-bot: cr
>>
> 
> Hi Andrew. Thanks for the heads-up. Fixes are new features are 
> independent from each other. Should I still wait a week to send out the 
> patchset containing the new features?

If they are totally independent then there is no reason to wait for a week.
But be sure to base fixes on top of net.git while features on top of
net-next.git and put appropriate prefix in the patch subject.