netdev - Re: [PATCH net-next] selftests: drv-net: rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250828170705.GB31759@horms.kernel.org>
Date: Thu, 28 Aug 2025 18:07:05 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, shuah@...nel.org,
	ecree.xilinx@...il.com, gal@...dia.com,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: rss_ctx: fix the queue
 count check

On Wed, Aug 27, 2025 at 10:35:58AM -0700, Jakub Kicinski wrote:
> Commit 0d6ccfe6b319 ("selftests: drv-net: rss_ctx: check for all-zero keys")
> added a skip exception if NIC has fewer than 3 queues enabled,
> but it's just constructing the object, it's not actually rising
> this exception.
> 
> Before:
> 
>   # Exception| net.lib.py.utils.CmdExitFailure: Command failed: ethtool -X enp1s0 equal 3 hkey d1:cc:77:47:9d:ea:15:f2:b9:6c:ef:68:62:c0:45:d5:b0:99:7d:cf:29:53:40:06:3d:8e:b9:bc:d4:70:89:b8:8d:59:04:ea:a9:c2:21:b3:55:b8:ab:6b:d9:48:b4:bd:4c:ff:a5:f0:a8:c2
>   not ok 1 rss_ctx.test_rss_key_indir
> 
> After:
> 
>   ok 1 rss_ctx.test_rss_key_indir # SKIP Device has fewer than 3 queues (or doesn't support queue stats)
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>