netdev - Re: [PATCH net-next v2 4/6] net: dsa: lantiq_gswip: support offset of MII registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4b7d4e6-ad38-469c-8b88-65cb78f97de9@hauke-m.de>
Date: Thu, 28 Aug 2025 22:30:39 +0200
From: Hauke Mehrtens <hauke@...ke-m.de>
To: Daniel Golle <daniel@...rotopia.org>, Andrew Lunn <andrew@...n.ch>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Cc: Andreas Schirm <andreas.schirm@...mens.com>,
 Lukas Stockmann <lukas.stockmann@...mens.com>,
 Alexander Sverdlin <alexander.sverdlin@...mens.com>,
 Peter Christen <peter.christen@...mens.com>,
 Avinash Jayaraman <ajayaraman@...linear.com>, Bing tao Xu
 <bxu@...linear.com>, Liang Xu <lxu@...linear.com>,
 Juraj Povazanec <jpovazanec@...linear.com>,
 "Fanni (Fang-Yi) Chan" <fchan@...linear.com>,
 "Benny (Ying-Tsan) Weng" <yweng@...linear.com>,
 "Livia M. Rosu" <lrosu@...linear.com>, John Crispin <john@...ozen.org>
Subject: Re: [PATCH net-next v2 4/6] net: dsa: lantiq_gswip: support offset of
 MII registers

On 8/27/25 01:06, Daniel Golle wrote:
> The MaxLinear GSW1xx family got a single (R)(G)MII port at index 5 but
> the registers MII_PCDU and MII_CFG are those of port 0.
> Allow applying an offset for the port index to access those registers.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
> v2: no changes
> 
>   drivers/net/dsa/lantiq/lantiq_gswip.c | 12 ++++++++++--
>   drivers/net/dsa/lantiq/lantiq_gswip.h |  1 +
>   2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dsa/lantiq/lantiq_gswip.c b/drivers/net/dsa/lantiq/lantiq_gswip.c
> index 3e2a54569828..64e378852284 100644
> --- a/drivers/net/dsa/lantiq/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq/lantiq_gswip.c
....
> diff --git a/drivers/net/dsa/lantiq/lantiq_gswip.h b/drivers/net/dsa/lantiq/lantiq_gswip.h
> index 19bbe6fddf04..2df9c8e8cfd0 100644
> --- a/drivers/net/dsa/lantiq/lantiq_gswip.h
> +++ b/drivers/net/dsa/lantiq/lantiq_gswip.h
> @@ -233,6 +233,7 @@ struct gswip_hw_info {
>   	int max_ports;
>   	unsigned int allowed_cpu_ports;
>   	unsigned int mii_ports;
> +	int mii_port_reg_offset;

Maybe you should set the mii_port_reg_offset attribute explicitly to 0.

>   	const struct gswip_pce_microcode (*pce_microcode)[];
>   	size_t pce_microcode_size;
>   	enum dsa_tag_protocol tag_protocol;

Hauke