netdev - Re: [PATCH v2 net-next 2/3] inet: ping: remove ping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0d352b7-ee11-4a3d-9e76-289cf90fa6c5@huawei.com>
Date: Fri, 29 Aug 2025 15:13:22 +0800
From: Yue Haibing <yuehaibing@...wei.com>
To: Eric Dumazet <edumazet@...gle.com>
CC: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, David Ahern <dsahern@...nel.org>,
	<netdev@...r.kernel.org>, <eric.dumazet@...il.com>
Subject: Re: [PATCH v2 net-next 2/3] inet: ping: remove ping_hash()

On 2025/8/29 14:57, Eric Dumazet wrote:
> On Thu, Aug 28, 2025 at 11:47 PM Yue Haibing <yuehaibing@...wei.com> wrote:
>>
>> On 2025/8/29 0:41, Eric Dumazet wrote:
>>> There is no point in keeping ping_hash().
>>>
>>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>>> Reviewed-by: David Ahern <dsahern@...nel.org>
>>> ---
>>>  net/ipv4/ping.c | 10 ----------
>>>  net/ipv6/ping.c |  1 -
>>>  2 files changed, 11 deletions(-)
>>>
>>> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
>>> index 74a0beddfcc41d8ba17792a11a9d027c9d590bac..75e1b0f5c697653e79166fde5f312f46b471344a 100644
>>> --- a/net/ipv4/ping.c
>>> +++ b/net/ipv4/ping.c
>>> @@ -67,7 +67,6 @@ static inline u32 ping_hashfn(const struct net *net, u32 num, u32 mask)
>>>       pr_debug("hash(%u) = %u\n", num, res);
>>>       return res;
>>>  }
>>> -EXPORT_SYMBOL_GPL(ping_hash);
>>
>> The declaration should also be removed
>>
>> include/net/ping.h:58:void ping_unhash(struct sock *sk);
> 
> Right, but you probably meant

Sure，I have a copy_paste mistake.
> 
> include/net/ping.h:57:int ping_hash(struct sock *sk);