netdev - Re: [PATCH v1 net-next] docs: remove obsolete description about threaded NAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAywjhSDz3F1uieMEuaFAtE2AKYXcv+5FjcDv3d4+T5ddWhy6Q@mail.gmail.com>
Date: Fri, 29 Aug 2025 08:37:48 -0700
From: Samiullah Khawaja <skhawaja@...gle.com>
To: Kohei Enju <enjuk@...zon.com>
Cc: netdev@...r.kernel.org, linux-doc@...r.kernel.org, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v1 net-next] docs: remove obsolete description about
 threaded NAPI

On Thu, Aug 28, 2025 at 11:49 PM Kohei Enju <enjuk@...zon.com> wrote:
>
> Commit 2677010e7793 ("Add support to set NAPI threaded for individual
> NAPI") introduced threaded NAPI configuration per individual NAPI
> instance, however obsolete description that threaded NAPI is per device
> has remained.
>
> Remove the old description and clarify that only NAPI instances running
> in threaded mode spawn kernel threads by changing "Each NAPI instance"
> to "Each threaded NAPI instance".
>
> Cc: Samiullah Khawaja <skhawaja@...gle.com>
> Signed-off-by: Kohei Enju <enjuk@...zon.com>
> ---
>  Documentation/networking/napi.rst | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
> index a15754adb041..7dd60366f4ff 100644
> --- a/Documentation/networking/napi.rst
> +++ b/Documentation/networking/napi.rst
> @@ -433,9 +433,8 @@ Threaded NAPI
>
>  Threaded NAPI is an operating mode that uses dedicated kernel
>  threads rather than software IRQ context for NAPI processing.
> -The configuration is per netdevice and will affect all
> -NAPI instances of that device. Each NAPI instance will spawn a separate
> -thread (called ``napi/${ifc-name}-${napi-id}``).
> +Each threaded NAPI instance will spawn a separate thread
> +(called ``napi/${ifc-name}-${napi-id}``).
>
>  It is recommended to pin each kernel thread to a single CPU, the same
>  CPU as the CPU which services the interrupt. Note that the mapping
> --
> 2.48.1
>
>

Reviewed-by: Samiullah Khawaja <skhawaja@...gle.com>