netdev - Re: [PATCH net-next 06/11] virtio_net: Implement layer 2 ethtool flow rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74dd76fc-59fd-47b2-82cb-e03b0a3aeff1@nvidia.com>
Date: Fri, 29 Aug 2025 15:16:46 -0500
From: Dan Jurgens <danielj@...dia.com>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>, netdev@...r.kernel.org,
 mst@...hat.com, jasowang@...hat.com, alex.williamson@...hat.com,
 virtualization@...ts.linux.dev, pabeni@...hat.com
Cc: parav@...dia.com, shshitrit@...dia.com, yohadt@...dia.com
Subject: Re: [PATCH net-next 06/11] virtio_net: Implement layer 2 ethtool flow
 rules

On 8/29/25 1:39 PM, ALOK TIWARI wrote:
> 
> 
>> +static void calculate_flow_sizes(struct ethtool_rx_flow_spec *fs,
>> +     * header for each type of header in the match critea, and each
>> header
> 
> typo critea -> criteria
> 
>> +     * providing the mask for matching against.
>> +     */

>> +    calculate_flow_sizes(fs, &key_size, &classifier_size, &num_hdrs);
>> +
>> +    key = kzalloc(key_size, GFP_KERNEL);
>> +    if (!key)
>> +        return -ENOMEM;
>> +
>> +    /*
>> +     * virio_net_ff_obj_ff_classifier is already included in the
> 
> virio_net_ff_obj_ff_classifier -> virtio_net_ff_obj_ff_classifier
> 
>> +     * classifier_size.
>> +     */
>> +    c = kzalloc(classifier_size +
>> +            sizeof(struct virtnet_classifier) -
>> +            sizeof(struct virtio_net_resource_obj_ff_classifier),
>> +            GFP_KERNEL);
>> +    if (!c)
>> +        return -ENOMEM;
> 
> kfree(key) before returning -ENOMEM
> 
> 
> Thanks,
> Alok
> 

Thanks Alok. Applied those changes for v2.