[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id:
<175650062774.2336923.18117158864204534101.git-patchwork-notify@kernel.org>
Date: Fri, 29 Aug 2025 20:50:27 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Qingfang Deng <dqfext@...il.com>
Cc: mostrows@...thlink.net, andrew+netdev@...n.ch, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/2] pppoe: remove rwlock usage
Hello:
This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:
On Thu, 28 Aug 2025 09:20:16 +0800 you wrote:
> Like ppp_generic.c, convert the PPPoE socket hash table to use RCU for
> lookups and a spinlock for updates. This removes rwlock usage and allows
> lockless readers on the fast path.
>
> - Mark hash table and list pointers as __rcu.
> - Use spin_lock() to protect writers.
> - Readers use rcu_dereference() under rcu_read_lock(). All known callers
> of get_item() already hold the RCU read lock, so no additional locking
> is needed.
> - get_item() now uses refcount_inc_not_zero() instead of sock_hold() to
> safely take a reference. This prevents crashes if a socket is already
> in the process of being freed (sk_refcnt == 0).
> - Set SOCK_RCU_FREE to defer socket freeing until after an RCU grace
> period.
> - Move skb_queue_purge() into sk_destruct callback to ensure purge
> happens after an RCU grace period.
>
> [...]
Here is the summary with links:
- [net-next,v3,1/2] pppoe: remove rwlock usage
https://git.kernel.org/netdev/net-next/c/72cdc67e7fa7
- [net-next,v3,2/2] pppoe: drop sock reference counting on fast path
https://git.kernel.org/netdev/net-next/c/4f54dff818d7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists