netdev - Re: [PATCH v2 net-next 2/3] inet: ping: remove ping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df07de96-5b35-4e64-ae9d-41fcdb73d484@huawei.com>
Date: Fri, 29 Aug 2025 14:47:01 +0800
From: Yue Haibing <yuehaibing@...wei.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>,
	<netdev@...r.kernel.org>, <eric.dumazet@...il.com>
Subject: Re: [PATCH v2 net-next 2/3] inet: ping: remove ping_hash()

On 2025/8/29 0:41, Eric Dumazet wrote:
> There is no point in keeping ping_hash().
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: David Ahern <dsahern@...nel.org>
> ---
>  net/ipv4/ping.c | 10 ----------
>  net/ipv6/ping.c |  1 -
>  2 files changed, 11 deletions(-)
> 
> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
> index 74a0beddfcc41d8ba17792a11a9d027c9d590bac..75e1b0f5c697653e79166fde5f312f46b471344a 100644
> --- a/net/ipv4/ping.c
> +++ b/net/ipv4/ping.c
> @@ -67,7 +67,6 @@ static inline u32 ping_hashfn(const struct net *net, u32 num, u32 mask)
>  	pr_debug("hash(%u) = %u\n", num, res);
>  	return res;
>  }
> -EXPORT_SYMBOL_GPL(ping_hash);

The declaration should also be removed

include/net/ping.h:58:void ping_unhash(struct sock *sk);

>  
>  static inline struct hlist_head *ping_hashslot(struct ping_table *table,
>  					       struct net *net, unsigned int num)
> @@ -144,14 +143,6 @@ int ping_get_port(struct sock *sk, unsigned short ident)
>  }
>  EXPORT_SYMBOL_GPL(ping_get_port);
>  
> -int ping_hash(struct sock *sk)
> -{
> -	pr_debug("ping_hash(sk->port=%u)\n", inet_sk(sk)->inet_num);
> -	BUG(); /* "Please do not press this button again." */
> -
> -	return 0;
> -}
> -
>  void ping_unhash(struct sock *sk)
>  {
>  	struct inet_sock *isk = inet_sk(sk);
> @@ -1008,7 +999,6 @@ struct proto ping_prot = {
>  	.bind =		ping_bind,
>  	.backlog_rcv =	ping_queue_rcv_skb,
>  	.release_cb =	ip4_datagram_release_cb,
> -	.hash =		ping_hash,
>  	.unhash =	ping_unhash,
>  	.get_port =	ping_get_port,
>  	.put_port =	ping_unhash,
> diff --git a/net/ipv6/ping.c b/net/ipv6/ping.c
> index 82b0492923d458213ac7a6f9316158af2191e30f..d7a2cdaa26312b44f1fe502d3d40f3e27f961fa8 100644
> --- a/net/ipv6/ping.c
> +++ b/net/ipv6/ping.c
> @@ -208,7 +208,6 @@ struct proto pingv6_prot = {
>  	.recvmsg =	ping_recvmsg,
>  	.bind =		ping_bind,
>  	.backlog_rcv =	ping_queue_rcv_skb,
> -	.hash =		ping_hash,
>  	.unhash =	ping_unhash,
>  	.get_port =	ping_get_port,
>  	.put_port =	ping_unhash,