netdev - Re: [PATCH net] selftests: drv-net: csum: fix interface name for remote host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e207b2b-b0ae-496c-b545-01e9844ffa15@linux.dev>
Date: Sun, 31 Aug 2025 10:09:53 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org,
 willemb@...gle.com, linux-kselftest@...r.kernel.org, petrm@...dia.com
Subject: Re: [PATCH net] selftests: drv-net: csum: fix interface name for
 remote host

On 30/08/2025 19:38, Jakub Kicinski wrote:
> Use cfg.remote_ifname for arguments of remote command.
> Without this UDP tests fail in NIPA where local interface
> is called enp1s0 and remote enp0s4.
> 
> Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: shuah@...nel.org
> CC: willemb@...gle.com
> CC: petrm@...dia.com
> CC: linux-kselftest@...r.kernel.org
> ---
>   tools/testing/selftests/drivers/net/hw/csum.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/hw/csum.py b/tools/testing/selftests/drivers/net/hw/csum.py
> index cd23af875317..3e3a89a34afe 100755
> --- a/tools/testing/selftests/drivers/net/hw/csum.py
> +++ b/tools/testing/selftests/drivers/net/hw/csum.py
> @@ -17,7 +17,7 @@ from lib.py import bkg, cmd, wait_port_listen
>       ip_args = f"-{ipver} -S {cfg.remote_addr_v[ipver]} -D {cfg.addr_v[ipver]}"
>   
>       rx_cmd = f"{cfg.bin_local} -i {cfg.ifname} -n 100 {ip_args} -r 1 -R {extra_args}"
> -    tx_cmd = f"{cfg.bin_remote} -i {cfg.ifname} -n 100 {ip_args} -r 1 -T {extra_args}"
> +    tx_cmd = f"{cfg.bin_remote} -i {cfg.remote_ifname} -n 100 {ip_args} -r 1 -T {extra_args}"
>   
>       with bkg(rx_cmd, exit_wait=True):
>           wait_port_listen(34000, proto="udp")
> @@ -37,7 +37,7 @@ from lib.py import bkg, cmd, wait_port_listen
>       if extra_args != "-U -Z":
>           extra_args += " -r 1"
>   
> -    rx_cmd = f"{cfg.bin_remote} -i {cfg.ifname} -L 1 -n 100 {ip_args} -R {extra_args}"
> +    rx_cmd = f"{cfg.bin_remote} -i {cfg.remote_ifname} -L 1 -n 100 {ip_args} -R {extra_args}"
>       tx_cmd = f"{cfg.bin_local} -i {cfg.ifname} -L 1 -n 100 {ip_args} -T {extra_args}"
>   
>       with bkg(rx_cmd, host=cfg.remote, exit_wait=True):

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>