netdev - Re: [PATCH net v1] Fixes: xircom auto-negoation timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202508312115.rbF0CO44-lkp@intel.com>
Date: Sun, 31 Aug 2025 22:11:05 +0800
From: kernel test robot <lkp@...el.com>
To: Alex Tran <alex.t.tran@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>
Cc: oe-kbuild-all@...ts.linux.dev, "David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alex Tran <alex.t.tran@...il.com>
Subject: Re: [PATCH net v1] Fixes: xircom auto-negoation timer

Hi Alex,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Tran/Fixes-xircom-auto-negoation-timer/20250825-093026
base:   net/main
patch link:    https://lore.kernel.org/r/20250825012821.492355-1-alex.t.tran%40gmail.com
patch subject: [PATCH net v1] Fixes: xircom auto-negoation timer
config: i386-randconfig-r073-20250831 (https://download.01.org/0day-ci/archive/20250831/202508312115.rbF0CO44-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508312115.rbF0CO44-lkp@intel.com/

New smatch warnings:
drivers/net/ethernet/xircom/xirc2ps_cs.c:1643 init_mii() warn: inconsistent indenting

Old smatch warnings:
drivers/net/ethernet/xircom/xirc2ps_cs.c:1208 xirc2ps_tx_timeout_task() warn: inconsistent indenting
drivers/net/ethernet/xircom/xirc2ps_cs.c:1685 init_mii() warn: inconsistent indenting

vim +1643 drivers/net/ethernet/xircom/xirc2ps_cs.c

  1633	
  1634	/****************
  1635	 * Initialize the Media-Independent-Interface
  1636	 * Returns: True if we have a good MII
  1637	 */
  1638	static int
  1639	init_mii(struct net_device *dev)
  1640	{
  1641	    struct local_info *local = netdev_priv(dev);
  1642	    unsigned int ioaddr = dev->base_addr;
> 1643		unsigned int control, status;
  1644	
  1645	    if (if_port == 4 || if_port == 1) { /* force 100BaseT or 10BaseT */
  1646		dev->if_port = if_port;
  1647		local->probe_port = 0;
  1648		return 1;
  1649	    }
  1650	
  1651	    status = mii_rd(ioaddr,  0, 1);
  1652	    if ((status & 0xff00) != 0x7800)
  1653		return 0; /* No MII */
  1654	
  1655	    local->new_mii = (mii_rd(ioaddr, 0, 2) != 0xffff);
  1656	    
  1657	    if (local->probe_port)
  1658		control = 0x1000; /* auto neg */
  1659	    else if (dev->if_port == 4)
  1660		control = 0x2000; /* no auto neg, 100mbs mode */
  1661	    else
  1662		control = 0x0000; /* no auto neg, 10mbs mode */
  1663	    mii_wr(ioaddr,  0, 0, control, 16);
  1664	    udelay(100);
  1665	    control = mii_rd(ioaddr, 0, 0);
  1666	
  1667	    if (control & 0x0400) {
  1668		netdev_notice(dev, "can't take PHY out of isolation mode\n");
  1669		local->probe_port = 0;
  1670		return 0;
  1671	    }
  1672	
  1673	    if (local->probe_port) {
  1674		/* according to the DP83840A specs the auto negotiation process
  1675		 * may take up to 3.5 sec, so we use this also for our ML6692
  1676		 */
  1677		local->dev = dev;
  1678		local->autoneg_attempts = 0;
  1679		init_completion(&local->autoneg_done);
  1680		timer_setup(&local->timer, autoneg_timer, 0);
  1681		local->timer.expires = RUN_AT(AUTONEG_TIMEOUT); /* 100msec intervals*/
  1682		add_timer(&local->timer);
  1683		}
  1684	
  1685		return 1;
  1686	}
  1687	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki