netdev - Re: [RFC net-next 11/17] net/dibs: Move struct device to dibs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dc3e8b1-c3c0-4939-86ca-578496a6efff@linux.ibm.com>
Date: Mon, 1 Sep 2025 14:46:01 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: dust.li@...ux.alibaba.com, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "D. Wythe" <alibuda@...ux.alibaba.com>,
        Sidraya Jayagond <sidraya@...ux.ibm.com>,
        Wenjia Zhang
 <wenjia@...ux.ibm.com>,
        Julian Ruess <julianr@...ux.ibm.com>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>,
        Simon Horman <horms@...nel.org>,
        Mahanta Jambigi <mjambigi@...ux.ibm.com>,
        Tony Lu
 <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>,
        Halil Pasic <pasic@...ux.ibm.com>, linux-rdma@...r.kernel.org
Subject: Re: [RFC net-next 11/17] net/dibs: Move struct device to dibs_dev



On 15.08.25 17:18, Dust Li wrote:
> On 2025-08-15 13:59:49, Alexandra Winter wrote:
>>
>> On 15.08.25 03:56, Dust Li wrote:
>>> On 2025-08-14 10:51:27, Alexandra Winter wrote:
>>>> On 06.08.25 17:41, Alexandra Winter wrote:
>>>> [...]
>>>>> Replace smcd->ops->get_dev(smcd) by dibs_get_dev().
>>>>>
>>>> Looking at the resulting code, I don't really like this concept of a *_get_dev() function,
>>>> that does not call get_device().
>>>> I plan to replace that by using dibs->dev directly in the next version.
>>> May I ask why? Because of the function name ? If so, maybe we can change the name.
>> Yes the name. Especially, as it is often used as argument for get_device() or put_device().
>> Eventually I would like to provide dibs_get_dev()/dibs_put_dev() that actually
>> do refcounting.
>> And then I thought defining dibs_read_dev() is not helping readability.
> I see. I don't like dibs_get_dev() either.
> What about dibs_device_to_dev() or dibs_to_dev() ?
> 
> If we can't agree on a name we’re all happy with, I agree we can
> leave it as is for now.
> 

I'd rather leave it as it is and leave it to future patches to provide
dibs_get_dev()/dibs_put_dev() and maybe also dibs_devname() service functions.