netdev - Re: [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61914df7e54eb4279627697ceb11f8aae0e5b77b.camel@codeconstruct.com.au>
Date: Mon, 01 Sep 2025 08:59:28 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>, admiyo@...amperecomputing.com, 
 Matt Johnston <matt@...econstruct.com.au>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Sudeep Holla
	 <sudeep.holla@....com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Huisong Li <lihuisong@...wei.com>
Subject: Re: [PATCH net-next v25 1/1] mctp pcc: Implement MCTP over PCC
 Transport

Hi Adam,

+1 on all the recommended changes from Alok, except for:

> > +               return -EINVAL;
> > +       }
> > +
> > +       snprintf(name, sizeof(name), "mctpipcc%d", context.inbox_index);
> 
> mctp_pcc%d ?

Please keep this as you have in v27, as mctppcc%d, so we're consistent
with other MCTP interface naming.

Cheers,



Jeremy