netdev - Re: [PATCH net-next v2 2/2] net: wangxun: add RSS reta and rxfh fields support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250901135142.174698ef@kernel.org>
Date: Mon, 1 Sep 2025 13:51:42 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Alexander
 Lobakin <aleksander.lobakin@...el.com>, Mengyuan Lou
 <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v2 2/2] net: wangxun: add RSS reta and rxfh
 fields support

On Fri, 29 Aug 2025 17:17:52 +0800 Jiawen Wu wrote:
> +		u32 max_queues = min_t(u32, wx->num_rx_queues,
> +				       WX_RSS_INDIR_TBL_MAX);
> +
> +		/*Allow at least 2 queues w/ SR-IOV.*/
> +		if (test_bit(WX_FLAG_SRIOV_ENABLED, wx->flags) &&
> +		    max_queues < 2)
> +			max_queues = 2;
> +
> +		/* Verify user input. */
> +		for (i = 0; i < reta_entries; i++)
> +			if (rxfh->indir[i] >= max_queues)
> +				return -EINVAL;

This looks suspicious, if you report the right number of rings from
GRXRINGS the core will do the check for you.
-- 
pw-bot: cr