netdev - Re: [PATCH net-next 1/2] selftests: drv-net: rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250902090156.GU15473@horms.kernel.org>
Date: Tue, 2 Sep 2025 10:01:56 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, ecree.xilinx@...il.com,
	gal@...dia.com, joe@...a.to, linux-kselftest@...r.kernel.org,
	shuah@...nel.org
Subject: Re: [PATCH net-next 1/2] selftests: drv-net: rss_ctx: use Netlink
 for timed reconfig

On Mon, Sep 01, 2025 at 10:26:07AM -0700, Jakub Kicinski wrote:
> On Mon, 1 Sep 2025 14:50:08 +0100 Simon Horman wrote:
> > > -    key = _rss_key_rand(key_len)
> > > +    ethnl = EthtoolFamily()
> > > +    key = random.randbytes(key_len)  
> > 
> > Is the update to the generation of key intended?
> > It's not clear to me how it relates to the rest of the patch.
> 
> _rss_key_rand() gives us an array of integers in the range 0-255 while
> randomg.randbytes() gives us a bytearray. Difference in return type.

Thanks, it is clear now :)

> Let me respin and add this to the commit msg. Looks like I was too
> aggressive with the decrease in 75msec timing, CI hit a 120msec run :(
>