netdev - RE: [PATCH v4 net-next 4/5] net: fec: add change_mtu to support dynamic buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510566654C4F2D9CF4576088806A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Tue, 2 Sep 2025 01:29:17 +0000
From: Wei Fang <wei.fang@....com>
To: Shenwei Wang <shenwei.wang@....com>
CC: Clark Wang <xiaoning.wang@....com>, Stanislav Fomichev <sdf@...ichev.me>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, John
 Fastabend <john.fastabend@...il.com>
Subject: RE: [PATCH v4 net-next 4/5] net: fec: add change_mtu to support
 dynamic buffer allocation

> > > +	/* Stop TX/RX and free the buffers */
> > > +	napi_disable(&fep->napi);
> > > +	netif_tx_disable(ndev);
> > > +	read_poll_timeout(fec_enet_rx_napi, done, (done == 0),
> > > +			  10, 1000, false, &fep->napi, 10);
> > > +	fec_stop(ndev);
> > > +
> > > +	WRITE_ONCE(ndev->mtu, new_mtu);
> > > +
> > > +	if (fep->pagepool_order != old_order) {
> >
> > If fep->pagepool_order is not changed, why need to stop TX/RX?
> >
> 
> The purpose is to update the MAX_FL based on the new mtu.

Thanks for the explanation, it would be better to add a comment here
to make it easier for readers to understand. :)