netdev - Re: [PATCH net v4] selftests: net: add test for destination in broadcast packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLbGDJ7Qk7YEq60q@karahi.gladserv.com>
Date: Tue, 2 Sep 2025 12:25:16 +0200
From: Brett Sheffield <bacs@...recast.net>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Oscar Maes <oscmaes92@...il.com>, netdev@...r.kernel.org,
	kuba@...nel.org, davem@...emloft.net, dsahern@...nel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH net v4] selftests: net: add test for destination in
 broadcast packets

On 2025-09-02 11:57, Paolo Abeni wrote:
> 
> 
> On 9/2/25 11:33 AM, Brett Sheffield wrote:
> > On 2025-09-02 10:49, Paolo Abeni wrote:
> >> On 8/28/25 1:42 PM, Oscar Maes wrote:
> >>> Add test to check the broadcast ethernet destination field is set
> >>> correctly.
> >>>
> >>> This test sends a broadcast ping, captures it using tcpdump and
> >>> ensures that all bits of the 6 octet ethernet destination address
> >>> are correctly set by examining the output capture file.
> >>>
> >>> Signed-off-by: Oscar Maes <oscmaes92@...il.com>
> >>> Co-authored-by: Brett A C Sheffield <bacs@...recast.net>
> >>
> >> I'm sorry for nit-picking, but the sob/tag-chain is wrong, please have a
> >> look at:
> >>
> >> https://elixir.bootlin.com/linux/v6.16.4/source/Documentation/process/submitting-patches.rst#L516
> > 
> > Thanks Paolo. So, something like:
> > 
> > Co-developed-by: Brett A C Sheffield <bacs@...recast.net>
> > Signed-off-by: Brett A C Sheffield <bacs@...recast.net>
> > Co-developed-by: Oscar Maes <oscmaes92@...il.com>
> > Signed-off-by: Oscar Maes <oscmaes92@...il.com>
> > 
> > with the last sign-off by Oscar because he is submitting?
> 
> Actually my understanding is:
> 
> Co-developed-by: Brett A C Sheffield <bacs@...recast.net>
> Signed-off-by: Brett A C Sheffield <bacs@...recast.net>
> Signed-off-by: Oscar Maes <oscmaes92@...il.com>
> 
> (if the patch is submitted by Oscar.) Basically the first examples in
> the doc, with the only differences that such examples lists 3 co-developers.

Ah yes, you are correct. I missed the "in addition to the author attributed by
the From: tag" bit.

Thanks again.


Brett