netdev - Re: [PATCH v2] net: intel: fm10k: Fix parameter idx set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <crnofgnchveaeduom44nzbq26m2zudy4wut3pl7xgf3fwar46n@tzvxk3nwlgmq>
Date: Tue, 2 Sep 2025 16:17:11 +0530
From: Brahmajit Das <listout@...tout.xyz>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: andrew+netdev@...n.ch, anthony.l.nguyen@...el.com, davem@...emloft.net, 
	intel-wired-lan@...ts.osuosl.org, kuba@...nel.org, netdev@...r.kernel.org, 
	przemyslaw.kitszel@...el.com
Subject: Re: [PATCH v2] net: intel: fm10k: Fix parameter idx set but not used

On 02.09.2025 11:34, Vadim Fedorenko wrote:
> On 02/09/2025 08:24, Brahmajit Das wrote:
> > Variable idx is set in the loop, but is never used resulting in dead
> > code. Building with GCC 16, which enables
> > -Werror=unused-but-set-parameter= by default results in build error.
> > This patch removes the idx parameter, since all the callers of the
> > fm10k_unbind_hw_stats_q as 0 as idx anyways.
> > 
> > Suggested-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> > Signed-off-by: Brahmajit Das <listout@...tout.xyz>
> > ---
> > changes in v2:
> > 	- Removed the idx parameter, since all callers of
> > 	fm10k_unbind_hw_stats_q passes idx as 0 anyways.
> Just a reminder that you shouldn't send another version of the patch
> as a reply to the previous version. And you have to wait for at least
> 24h before sending next version to let other reviewers look at the code.
> Current submission looks OK in patchwork, so no action is needed from
> you right now.
> 
> Thanks,
> Vadim

Noted, thank you.
-- 
Regards,
listout