netdev - Re: [PATCH net-next] net_sched: add back BH safety to tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLHz+dVuOv7p4LG00FqCe2tnKom3hAT=Hum8G15OePxuw@mail.gmail.com>
Date: Tue, 2 Sep 2025 05:12:47 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next] net_sched: add back BH safety to tcf_lock

On Tue, Sep 2, 2025 at 4:56 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> On Mon, Sep 1, 2025 at 5:26 AM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > Jamal reported that we had to use BH safety after all,
> > because stats can be updated from BH handler.
> >
> > Fixes: 3133d5c15cb5 ("net_sched: remove BH blocking in eight actions")
> > Fixes: 53df77e78590 ("net_sched: act_skbmod: use RCU in tcf_skbmod_dump()")
> > Fixes: e97ae742972f ("net_sched: act_tunnel_key: use RCU in tunnel_key_dump()")
> > Fixes: 48b5e5dbdb23 ("net_sched: act_vlan: use RCU in tcf_vlan_dump()")
> > Reported-by: Jamal Hadi Salim <jhs@...atatu.com>
> > Closes: https://lore.kernel.org/netdev/CAM0EoMmhq66EtVqDEuNik8MVFZqkgxFbMu=fJtbNoYD7YXg4bA@mail.gmail.com/
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>
> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>
>
> Eric - i dont think this will fix that lockdep splat i was referring
> to though, no?

It should since we go back to the situation before
3133d5c15cb5 ("net_sched: remove BH blocking in eight actions")
as far as locking is concerned ?

Do you have a lockdep splat to share ?