netdev - Re: [PATCH net-next 5/8] selftests: traceroute: Use require

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ba001d8-9cae-44e0-9ba9-c2bbc8194a92@kernel.org>
Date: Mon, 1 Sep 2025 20:38:15 -0600
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, horms@...nel.org, paul@...l-moore.com,
 petrm@...dia.com, linux-security-module@...r.kernel.org
Subject: Re: [PATCH net-next 5/8] selftests: traceroute: Use require_command()

On 9/1/25 2:30 AM, Ido Schimmel wrote:
> Use require_command() so that the test will return SKIP (4) when a
> required command is not present.
> 
> Before:
> 
>  # ./traceroute.sh
>  SKIP: Could not run IPV6 test without traceroute6
>  SKIP: Could not run IPV4 test without traceroute
>  $ echo $?
>  0
> 
> After:
> 
>  # ./traceroute.sh
>  TEST: traceroute6 not installed                                    [SKIP]
>  $ echo $?
>  4
> 
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  tools/testing/selftests/net/traceroute.sh | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>