netdev - Re: [PATCH net-next 0/4] net: stmmac: new features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68975e58-9018-484d-b8c1-2afcb1ad606a@lunn.ch>
Date: Tue, 2 Sep 2025 23:17:34 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Joseph Steel <recv.jo@...il.com>,
	Konrad Leszczynski <konrad.leszczynski@...el.com>,
	davem@...emloft.net, andrew+netdev@...n.ch, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, cezary.rojewski@...el.com,
	sebastian.basierski@...el.com
Subject: Re: [PATCH net-next 0/4] net: stmmac: new features

> >> The series looks good to me.
> >>
> >> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> > 
> > Not a single comment? Really? Three Rb and three Sb tags from Intel
> > staff and nobody found even a tiny problem? Sigh...
> > 
> 
> Not everyone will find every issue. I'm certainly no expert in this
> driver. This is why it is good to have many reviewers.

As a rule of thumb, Maintainers ignore multiple Reviewed-by when then
call come from the same company. At least if they don't actually point
out issues.

There is a nice quote from a bootlin/free-electrons developer. It is
something like: In order to get my patches merged faster, i review
other peoples patches, so freeing up Maintainer time to look at my
patches.

Jacob is a good example of that, he looks at patches from many
developers. Maybe more Intel people can help out reviewing patches,
particularly other stmmac patches, in order to get their own merged?

	Andrew