netdev - Re: [PATCH net] net/smc: Remove validation of reserved bits in CLC Decline message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250902070831.GA168966@horms.kernel.org>
Date: Tue, 2 Sep 2025 08:08:31 +0100
From: Simon Horman <horms@...nel.org>
To: Mahanta Jambigi <mjambigi@...ux.ibm.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, alibuda@...ux.alibaba.com,
	dust.li@...ux.alibaba.com, sidraya@...ux.ibm.com,
	wenjia@...ux.ibm.com, pasic@...ux.ibm.com, tonylu@...ux.alibaba.com,
	guwen@...ux.alibaba.com, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org,
	Alexandra Winter <wintera@...ux.ibm.com>
Subject: Re: [PATCH net] net/smc: Remove validation of reserved bits in CLC
 Decline message

On Fri, Aug 29, 2025 at 12:26:26PM +0200, Mahanta Jambigi wrote:
> Currently SMC code is validating the reserved bits while parsing the incoming
> CLC decline message & when this validation fails, its treated as a protocol
> error. As a result, the SMC connection is terminated instead of falling back to
> TCP. As per RFC7609[1] specs we shouldn't be validating the reserved bits that
> is part of CLC message. This patch fixes this issue.
> 
> CLC Decline message format can viewed here[2].
> 
> [1] https://datatracker.ietf.org/doc/html/rfc7609#page-92
> [2] https://datatracker.ietf.org/doc/html/rfc7609#page-105
> 
> Fixes: 8ade200(net/smc: add v2 format of CLC decline message)
> 

Hi Mahanta,

Sorry to nit-pick, but there should not be a blank line here.
And the correct format for the Fixes tag, whith at least
12 characters of hash, is:

Fixes: 8ade200c269f ("net/smc: add v2 format of CLC decline message")

> Signed-off-by: Mahanta Jambigi <mjambigi@...ux.ibm.com>
> Reference-ID: LTC214332

Please drop this non-standard tag.
And please only include references (by any means) to public information.

> Reviewed-by: Sidraya Jayagond <sidraya@...ux.ibm.com>
> Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>

...