lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <11a4d0a953e3a9405177d67f287c69379a2b2f8f.camel@physik.fu-berlin.de>
Date: Tue, 02 Sep 2025 09:15:08 +0200
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Andreas Larsson <andreas@...sler.com>,
 schuster.simon@...mens-energy.com,  Dinh Nguyen <dinguyen@...nel.org>,
 Christian Brauner <brauner@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
 Andrew Morton <akpm@...ux-foundation.org>, David Hildenbrand
 <david@...hat.com>, Lorenzo Stoakes	 <lorenzo.stoakes@...cle.com>, "Liam R.
 Howlett" <Liam.Howlett@...cle.com>,  Vlastimil Babka	 <vbabka@...e.cz>,
 Mike Rapoport <rppt@...nel.org>, Suren Baghdasaryan	 <surenb@...gle.com>,
 Michal Hocko <mhocko@...e.com>, Ingo Molnar	 <mingo@...hat.com>, Peter
 Zijlstra <peterz@...radead.org>, Juri Lelli	 <juri.lelli@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>,  Dietmar Eggemann
 <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, Ben
 Segall <bsegall@...gle.com>,  Mel Gorman <mgorman@...e.de>, Valentin
 Schneider <vschneid@...hat.com>, Kees Cook <kees@...nel.org>,  Paul
 Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>,  Alexandre Ghiti	 <alex@...ti.fr>, Guo
 Ren <guoren@...nel.org>, Oleg Nesterov <oleg@...hat.com>,  Jens Axboe
 <axboe@...nel.dk>, Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara
 <jack@...e.cz>, Tejun Heo <tj@...nel.org>, Johannes Weiner
 <hannes@...xchg.org>, Michal Koutný	 <mkoutny@...e.com>,
 Paul Moore <paul@...l-moore.com>, Serge Hallyn	 <sergeh@...nel.org>, James
 Morris <jmorris@...ei.org>, "Serge E. Hallyn"	 <serge@...lyn.com>,
 Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker
 <frederic@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Masami
 Hiramatsu	 <mhiramat@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet	 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni	 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Mathieu
 Desnoyers	 <mathieu.desnoyers@...icios.com>, Arnaldo Carvalho de Melo
 <acme@...nel.org>,  Namhyung Kim <namhyung@...nel.org>, Mark Rutland
 <mark.rutland@....com>, Alexander Shishkin	
 <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, Ian
 Rogers	 <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, John
 Johansen	 <john.johansen@...onical.com>, Stephen Smalley
 <stephen.smalley.work@...il.com>,  Ondrej Mosnacek <omosnace@...hat.com>,
 Kentaro Takeda <takedakn@...data.co.jp>, Tetsuo Handa	
 <penguin-kernel@...ove.SAKURA.ne.jp>, Richard Henderson	
 <richard.henderson@...aro.org>, Matt Turner <mattst88@...il.com>, Vineet
 Gupta	 <vgupta@...nel.org>, Russell King <linux@...linux.org.uk>, Catalin
 Marinas	 <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Brian
 Cain	 <bcain@...nel.org>, Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui	
 <kernel@...0n.name>, Geert Uytterhoeven <geert@...ux-m68k.org>, Michal
 Simek	 <monstr@...str.eu>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Jonas Bonn	 <jonas@...thpole.se>, Stefan Kristiansson
 <stefan.kristiansson@...nalahti.fi>,  Stafford Horne <shorne@...il.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, Helge
 Deller	 <deller@....de>, Madhavan Srinivasan <maddy@...ux.ibm.com>, Michael
 Ellerman	 <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Christophe Leroy	 <christophe.leroy@...roup.eu>, Heiko Carstens
 <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger	
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Yoshinori
 Sato <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, Richard
 Weinberger	 <richard@....at>, Anton Ivanov
 <anton.ivanov@...bridgegreys.com>, Johannes Berg	
 <johannes@...solutions.net>, Borislav Petkov <bp@...en8.de>, Dave Hansen	
 <dave.hansen@...ux.intel.com>, x86@...nel.org, "H. Peter Anvin"
 <hpa@...or.com>,  Chris Zankel <chris@...kel.net>, Max Filippov
 <jcmvbkbc@...il.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, linux-csky@...r.kernel.org, 
	linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	cgroups@...r.kernel.org, linux-security-module@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org, 
	linux-perf-users@...r.kernel.org, apparmor@...ts.ubuntu.com, 
	selinux@...r.kernel.org, linux-alpha@...r.kernel.org, 
	linux-snps-arc@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, 
	linux-hexagon@...r.kernel.org, loongarch@...ts.linux.dev, 
	linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org, 
	linux-openrisc@...r.kernel.org, linux-parisc@...r.kernel.org, 
	linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org, 
	linux-sh@...r.kernel.org, sparclinux@...r.kernel.org, 
	linux-um@...ts.infradead.org
Subject: Re: [PATCH v2 3/4] arch: copy_thread: pass clone_flags as u64

Hi Andreas,

On Tue, 2025-09-02 at 09:02 +0200, Andreas Larsson wrote:
> On 2025-09-01 15:09, Simon Schuster via B4 Relay wrote:
> > From: Simon Schuster <schuster.simon@...mens-energy.com>
> > 
> > With the introduction of clone3 in commit 7f192e3cd316 ("fork: add
> > clone3") the effective bit width of clone_flags on all architectures was
> > increased from 32-bit to 64-bit, with a new type of u64 for the flags.
> > However, for most consumers of clone_flags the interface was not
> > changed from the previous type of unsigned long.
> > 
> > While this works fine as long as none of the new 64-bit flag bits
> > (CLONE_CLEAR_SIGHAND and CLONE_INTO_CGROUP) are evaluated, this is still
> > undesirable in terms of the principle of least surprise.
> > 
> > Thus, this commit fixes all relevant interfaces of the copy_thread
> > function that is called from copy_process to consistently pass
> > clone_flags as u64, so that no truncation to 32-bit integers occurs on
> > 32-bit architectures.
> > 
> > Signed-off-by: Simon Schuster <schuster.simon@...mens-energy.com>
> > ---
> 
> Thanks for this and for the whole series! Needed foundation for a
> sparc32 clone3 implementation as well.

Can you implement clone3 for sparc64 as well?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ