[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <jwnluocwcj2kubrxab74iyj65ehf7xm4wgifwdtce7jn5xawys@33a3vmcrjska>
Date: Tue, 2 Sep 2025 01:16:39 -0700
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, joe@...a.to,
sdf@...ichev.me, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] selftests: net: py: don't default to
shell=True
On Sat, Aug 30, 2025 at 11:43:17AM -0700, Jakub Kicinski wrote:
> Overhead of using shell=True is quite significant.
> Micro-benchmark of running ethtool --help shows that
> non-shell run is 2x faster.
>
> Runtime of the XDP tests also shows improvement:
> this patch: 2m34s 2m21s 2m18s 2m18s
> before: 2m54s 2m36s 2m34s
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Reviewed-by: Breno Leitao <leitao@...ian.org>
Powered by blists - more mailing lists