netdev - Re: [PATCH net] net: phylink: move PHY interrupt request to non-fail path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <093c8097-2b74-4678-a9b0-08f1ab0add63@lunn.ch>
Date: Wed, 3 Sep 2025 02:56:26 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] net: phylink: move PHY interrupt request to non-fail
 path

> +	if (ret == 0 && phy_interrupt_is_valid(phy))
> +		phy_request_interrupt(phy);
> +

ret == 0 is a bit of an anti pattern, but O.K:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew