netdev - Re: [PATCH net-next] bonding: Remove support for use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e40b97a-ceeb-4f0a-87cf-801520217916@blackwall.org>
Date: Wed, 3 Sep 2025 12:53:52 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Stanislav Fomichev <stfomichev@...il.com>, Jay Vosburgh <jv@...sburgh.net>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Jonathan Corbet <corbet@....net>, Andrew Lunn <andrew+netdev@...n.ch>,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next] bonding: Remove support for use_carrier

On 9/3/25 12:50, Nikolay Aleksandrov wrote:
> On 9/2/25 19:11, Stanislav Fomichev wrote:
>> On 08/29, Jay Vosburgh wrote:
[snip]
>>>       return 0;
>>
>> Acked-by: Stanislav Fomichev <sdf@...ichev.me>
>>
>> nit: any reason not to return -EINVAL here when the new value is not "1"?
>> You do it for the module param, but not for the sysfs file here.
>>
> 
> bond options code already returns EINVAL for values not described in the option's value
> table, after Jay removed "0" from there it should automatically cause -EINVAL to be returned
> 
> 

Still fixing email problems, I see now that this is an old thread.
Please ignore my reply, sorry for the noise!

Cheers,
  Nik