netdev - Re: [PATCH net-next v10 00/19] add basic PSP encryption for TCP connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLjAefFr3VqEWDJ1@x130>
Date: Wed, 3 Sep 2025 15:26:01 -0700
From: Saeed Mahameed <saeed@...nel.org>
To: Daniel Zahka <daniel.zahka@...il.com>
Cc: Donald Hunter <donald.hunter@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Saeed Mahameed <saeedm@...dia.com>,
	Leon Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
	Boris Pismenny <borisp@...dia.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Willem de Bruijn <willemb@...gle.com>,
	David Ahern <dsahern@...nel.org>,
	Neal Cardwell <ncardwell@...gle.com>,
	Patrisious Haddad <phaddad@...dia.com>,
	Raed Salem <raeds@...dia.com>, Jianbo Liu <jianbol@...dia.com>,
	Dragos Tatulea <dtatulea@...dia.com>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Toke Høiland-Jørgensen <toke@...hat.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Kiran Kella <kiran.kella@...adcom.com>,
	Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v10 00/19] add basic PSP encryption for TCP
 connections

On 03 Sep 11:51, Daniel Zahka wrote:
>
>
>On 9/2/25 3:41 PM, Saeed Mahameed wrote:
>>On 28 Aug 09:29, Daniel Zahka wrote:
>>>.../mellanox/mlx5/core/en_accel/psp.c | 195 +++++
>>>.../mellanox/mlx5/core/en_accel/psp.h         |  49 ++
>>>.../mellanox/mlx5/core/en_accel/psp_fs.c      | 736 ++++++++++++++++++
>>>.../mellanox/mlx5/core/en_accel/psp_fs.h      |  30 +
>>>.../mellanox/mlx5/core/en_accel/psp_offload.c |  44 ++
>>
>>A bit too much control path files, psp_offload.c holds only two level
>>functions for key management and rotation, while psp_fs is.c 
>>implementing the flow steering part and psp.c is the netdev API 
>>facing implementation,
>>do we really need three files ? You can sparate the logic inside one file
>>by bottom up design rather than 3 split files.
>>psp is a well defined protocol, I don't expect it to scale larger than a
>>1-2k lines of code in mlx5, so let's keep it simple, just consolidate all
>>files into one en_accel/psp.{c,h} and leave rxtx.c data path separate.
>>
>>Also As Jakub pointed out on V7, mlx5_ifc changes need to be 
>>separated into
>>own patch, "net/mlx5e: Support PSP offload functionality" need to 
>>split at
>>the point where we cache ps caps on driver load, so main.c and 
>>mlx5_if.c in
>>that patch have to go into own patch and then pulled into mlx5-next 
>>branch
>>to avoid any conflict. Let me know if you need any assistance.
>>
>>
>>>.../mellanox/mlx5/core/en_accel/psp_rxtx.c | 200 +++++
>>>.../mellanox/mlx5/core/en_accel/psp_rxtx.h    | 121 +++
>>>.../net/ethernet/mellanox/mlx5/core/en_main.c |   9 +
>>>.../net/ethernet/mellanox/mlx5/core/en_rx.c   |  49 +-
>>>.../net/ethernet/mellanox/mlx5/core/en_tx.c   |  10 +-
>>>drivers/net/ethernet/mellanox/mlx5/core/fw.c  |   6 +
>>>.../ethernet/mellanox/mlx5/core/lib/crypto.h  |   1 +
>>>.../net/ethernet/mellanox/mlx5/core/main.c    |   1 +
>>>.../mellanox/mlx5/core/steering/hws/definer.c |   2 +-
>>
>
>Hello Saeed,
>I want confirm that I understand the ask here. So, I will consolidate 
>all of:
>
>.../mellanox/mlx5/core/en_accel/psp.c | 195 +++++
>.../mellanox/mlx5/core/en_accel/psp.h |  49 ++
>.../mellanox/mlx5/core/en_accel/psp_fs.c | 736 ++++++++++++++++++
>.../mellanox/mlx5/core/en_accel/psp_fs.h |  30 +
>.../mellanox/mlx5/core/en_accel/psp_offload.c |  44 ++
>
>into en_accel/psp.[ch]. And then for the ifc changes, I will rebase 
>after your PR is merged. And then no action is needed beyond that on 
>the other files. Is that right?
>

Yes, The PR was just pulled into net-next.