netdev - Re: [PATCH net 1/2] selftests: netfilter: fix udpclash tool hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250903160944.27826c84@kernel.org>
Date: Wed, 3 Sep 2025 16:09:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Florian Westphal <fw@...len.de>
Cc: netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 netfilter-devel@...r.kernel.org, pablo@...filter.org
Subject: Re: [PATCH net 1/2] selftests: netfilter: fix udpclash tool hang

On Thu, 4 Sep 2025 00:52:20 +0200 Florian Westphal wrote:
> Jakub Kicinski <kuba@...nel.org> wrote:
> > On Tue,  2 Sep 2025 20:58:54 +0200 Florian Westphal wrote:  
> > > Yi Chen reports that 'udpclash' loops forever depending on compiler
> > > (and optimization level used); while (x == 1) gets optimized into
> > > for (;;).  Switch to stdatomic to prevent this.  
> > 
> > gcc version 15.1.1 (F42) w/ whatever flags kselftests use appear to be
> > unaware of this macro:
> > 
> > udpclash.c:33:26: error: implicit declaration of function ‘ATOMIC_VAR_INIT’; did you mean ‘ATOMIC_FLAG_INIT’? [-Wimplicit-function-declaration]
> >    33 | static atomic_int wait = ATOMIC_VAR_INIT(1);
> >       |                          ^~~~~~~~~~~~~~~
> >       |                          ATOMIC_FLAG_INIT
> > udpclash.c:33:26: error: initializer element is not constant
> > Could you perhaps use volatile instead?  
> 
> That works too.  I'll send a new PR tomorrow, its late here.

👍️ FWIW I'll be sending the PR tomorrow so plenty time..