netdev - RE: [Intel-wired-lan] [PATCH v1 iwl-net] igb: fix link test skipping when interface is admin down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6241BC2E510C794CD17EDED38B01A@IA1PR11MB6241.namprd11.prod.outlook.com>
Date: Wed, 3 Sep 2025 03:50:43 +0000
From: "Rinitha, SX" <sx.rinitha@...el.com>
To: Kohei Enju <enjuk@...zon.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexander Duyck
	<alexander.h.duyck@...el.com>, "kohei.enju@...il.com" <kohei.enju@...il.com>
Subject: RE: [Intel-wired-lan] [PATCH v1 iwl-net] igb: fix link test skipping
 when interface is admin down

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Kohei Enju
> Sent: 15 August 2025 11:57
> To: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Alexander Duyck <alexander.h.duyck@...el.com>; kohei.enju@...il.com; Kohei Enju <enjuk@...zon.com>
> Subject: [Intel-wired-lan] [PATCH v1 iwl-net] igb: fix link test skipping when interface is admin down
>
> The igb driver incorrectly skips the link test when the network interface is admin down (if_running == false), causing the test to always report PASS regardless of the actual physical link state.
>
> This behavior is inconsistent with other drivers (e.g. i40e, ice, ixgbe,
etc.) which correctly test the physical link state regardless of admin state.
> Remove the if_running check to ensure link test always reflects the physical link state.
>
> Fixes: 8d420a1b3ea6 ("igb: correct link test not being run when link is down")
> Signed-off-by: Kohei Enju <enjuk@...zon.com>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@...el.com> (A Contingent worker at Intel)