[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aLluvYQ-i-Z9vyp7@shell.armlinux.org.uk>
Date: Thu, 4 Sep 2025 11:49:33 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Simon Horman <horms@...nel.org>
Cc: Yao Zi <ziyao@...root.org>, Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jonas Karlman <jonas@...boo.se>, David Wu <david.wu@...k-chips.com>,
Chaoyi Chen <chaoyi.chen@...k-chips.com>, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH net] net: stmmac: dwmac-rk: Ensure clk_phy doesn't
contain invalid address
On Thu, Sep 04, 2025 at 11:34:43AM +0100, Simon Horman wrote:
> Thanks, and sorry for my early confusion about applying this patch.
>
> I agree that the bug you point out is addressed by this patch.
> Although I wonder if it is cleaner not to set bsp_priv->clk_phy
> unless there is no error, rather than setting it then resetting
> it if there is an error.
+1 !
> More importantly, I wonder if there is another bug: does clk_set_rate need
> to be called in the case where there is no error and bsp_priv->integrated_phy
> is false?
I think there's another issue:
static int rk_gmac_clk_init(struct plat_stmmacenet_data *plat)
{
...
if (plat->phy_node) {
bsp_priv->clk_phy = of_clk_get(plat->phy_node, 0);
...
static void rk_gmac_remove(struct platform_device *pdev)
{
...
if (priv->plat->phy_node && bsp_priv->integrated_phy)
clk_put(bsp_priv->clk_phy);
So if bsp_priv->integrated_phy is false, then we get the clock but
don't put it.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists