netdev - Re: [RFC PATCH net-next] ppp: enable TX scatter-gather

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bcf9c1c9-996a-4fd4-902c-3bf797ca688d@lunn.ch>
Date: Thu, 4 Sep 2025 14:51:24 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Qingfang Deng <dqfext@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-ppp@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Felix Fietkau <nbd@....name>
Subject: Re: [RFC PATCH net-next] ppp: enable TX scatter-gather

> diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
> index f9f0f16c41d1..3bf37871a1aa 100644
> --- a/drivers/net/ppp/ppp_generic.c
> +++ b/drivers/net/ppp/ppp_generic.c
> @@ -1710,6 +1710,12 @@ pad_compress_skb(struct ppp *ppp, struct sk_buff *skb)
>  		ppp->xcomp->comp_extra + ppp->dev->hard_header_len;
>  	int compressor_skb_size = ppp->dev->mtu +
>  		ppp->xcomp->comp_extra + PPP_HDRLEN;
> +	/* Until we fix the compressor need to make sure data portion is
> +	 * linear.
> +	 */
> +	if (skb_linearize(skb))
> +		return NULL;

The word 'fix' suggest something is broken. I don't think that is
true, its just a limitation of the compressor. Please avoid 'fix'.

	Andrew